mismatch in test name convention between clojure-mode and clojure-test-mode. about clojure-mode HOT 9 CLOSED

@bonega can you take a look at this?

from clojure-mode.

Doing some work related travelling atm, but should be able to give it a look by the end of the week

from clojure-mode.

Just an FYI, the commit which made the opposite change is 2be006f.

from clojure-mode.

Fixed in this pull-request: #104

Is there any way to attach a pull-request to an existing issue?

from clojure-mode.

Thanks for the fix.

from clojure-mode.

Oops, sorry @bonega, this still has error 😒.

I don't know elisp and I couldn't figure out how to run some of the functions (like the code inside clojure-jump-to-test) so I can't provide code or tests, but here is the problem:

I have a namespace hours.views.common. When I try to switch to test mode it tried to create PROJECT/test/hours/test/views/test/common.clj (instead of PROJECT/test/hours/views/test/common.clj?). The code in clojure-test-mode works as (I think) it supposed to, from PROJECT/test/hours/views/test/common.clj to PROJECT/src/hours/views/common.clj.

Thanks

from clojure-mode.

Does this commit solve it for you?
bonega@22d213b

from clojure-mode.

This commit fixes the symmetry problem between clojure-mode and clojure-test-mode 😄.

I'm a little confused though, Is there a convention regarding test file naming? In the few months I've been playing with clojure the test name convention (for namespaces with more then one nested element) changed from one.two.test.three to one.two.three-test, and now one.test.two.three. I actually don'e care which of the above I use, but I was wondering is there a convention.

from clojure-mode.

Great, I have submitted a pullrequest.

As for the convention, I would guess that's whatever lein test uses.
@technomancy
Could you comment on this issue?

from clojure-mode.