Race condition: data race about smudge HOT 4 CLOSED

For more warning, https://pastebin.com/qZSrYc0k.

from smudge.

I wonder if these DATA RACE warnings are actually a problem or just, like notified, warnings.

I looked around a bit and more warnings can be resolved by locking access to variables but it is quite some work to get this right. Would it solve actually errors doing this?

from smudge.

As an example here is a commit that enables save access to the emitCounters but there are several more data race warnings beyond this change.

from smudge.

We can certainly do this, but these are primitive values that are only atomically incremented by design. They're designed to be modified by multiple threads.

As far as I can tell, everything that needs to be reads/write locked (the maps) is...

from smudge.