Comments (4)
The issue (bug) is that metadata isn't properly preserved in the conversion to s-expressions and back:
(comment
(def node (clj-kondo.impl.rewrite-clj.parser/parse-string "^Long foo"))
(:meta node) ;; => :token Long
(def sexpr (api/sexpr node)) ;; foo
(meta sexpr)
(def node2 (api/coerce sexpr))
(:meta node2) ;;=> nil
)
from clj-kondo.
Compare to the original rewrite-clj:
user=> (require '[rewrite-clj.parser :as p])
nil
user=> (p/parse-string "^Long foo")
<meta: ^Long foo>
user=> (def node (p/parse-string "^Long foo"))
#'user/node
user=> (require '[rewrite-clj.node :as n])
nil
user=> (n/sexpr n)
CompilerException java.lang.RuntimeException: Unable to resolve symbol: n in this context, compiling:(NO_SOURCE_PATH:5:1)
user=> (n/sexpr node)
foo
user=> (meta (n/sexpr node))
{Long true}
user=> (n/coerce (n/sexpr node))
<meta: ^{Long true} foo>
from clj-kondo.
The issue (bug) is that metadata isn't properly preserved in the conversion to s-expressions and back:
Is this fixable for clj-kondo?
from clj-kondo.
I hope so. Haven't looked into it yet.
from clj-kondo.
Related Issues (20)
- Static usage of ns-unmap not recognized HOT 1
- (Class/field) should warn HOT 2
- clojure.core/subs positions HOT 1
- Support a gitlab CI friendly output natively HOT 2
- Improved var-usages analysis for multimethods HOT 1
- Support clojure-lsp/unused-public-var for custom macros HOT 1
- False positive from not-a-function when using reader to read a record HOT 3
- Report var usage in `if`/`when` condition as always truthy
- Clojure 1.12 Alpha 7 param-tags placeholder not recognized HOT 3
- String* may also appear outside of metadata HOT 2
- Class/forName considered as function name (proposal: say that it must be a simple symbol) HOT 8
- False positive bigint in (extend-type bigint IDeref (-deref [_])) (CLJS 1.11.132)
- Warning due to shadowing of clojure.core/update-vals
- ambiguous unhinted method-as-function should warn about adding metadata HOT 1
- Lint files in topological sort order
- clj-kondo Pod - lint stdin HOT 1
- clj-kondo incorrectly flags method as field HOT 1
- Wrong unresolved error on defmacro HOT 1
- false positive(?) : Static fields should be referenced without parens unless they are intended as function calls HOT 6
- :case-symbol-test should warn on symbol in list
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clj-kondo.