Git Product home page Git Product logo

Comments (3)

KingMob avatar KingMob commented on June 11, 2024

One thing we could do is stick all internal keys in a map under a single key, like:

{:headers {...}
 :body ...
 :aleph/keep-alive? true
 :aleph/request-arrived some-nano-time
 :aleph/internal {:ch ch 
                  :gory-internal1 ...
                  :gory-internal2 ...}}

I think it's nice and tidy this way.

from aleph.

DerGuteMoritz avatar DerGuteMoritz commented on June 11, 2024

I think I slightly prefer the flat version because looking up a single internal key is more convenient then (most usage sites are only interested in one of them at a time I think). But the submap approach has the nice advantage that endusers can just dissoc that single key to rid the request map of the gory internals, so there's that.

Another alternative could be to store these in metadata (cf. how it's done for :aleph/channel on streams in the UDP, TCP and websocket implementations).

from aleph.

KingMob avatar KingMob commented on June 11, 2024

Flat version is fine, I don't care that much.

Please do not store them in metadata though. I've been wanting to remove that behavior because it violates expectations about what metadata is, and what it's attached to.

from aleph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.