Issue while using from remote connection about go-gh HOT 6 CLOSED

Seems like,

https://github.com/cli/browser/blob/419c10c56bd56293c8f898ef5c6be291eb099120/browser_linux.go#L8

here,

	providers := []string{"xdg-open", "x-www-browser", "www-browser", "wslview"}

provider is found but, XDG_SESSION_TYPE is tty, while watching the os env list

I can send a PR for this if accepted as a BUG.

from go-gh.

@leodahal4 Thanks for writing in with your issue. This sounds more like an incorrect local environment variable configuration than an issue with the package. What would your PR to fix this bug include?

from go-gh.

I have tried to check the os env variables and if the session's env contains XDG_SESSION_TYPE as tty then we can fail returning error as cannot execute the browser, and its working fine on mine CLI as without browser user can visit a predefined webpage. But seems like I should send the PR to https://github.com/cli/browser, right?

from go-gh.

This was failing for me recently and it was a WSL bug. Does invoking wslview manually work for you?

from go-gh.

no unfortunately as I am on arch Linux, and my environment doesnot include wslview

from go-gh.

@leodahal4 Thanks for following up. We have discussed this a bit further and we feel that checking XDG_SESSION_TYPE environment variable is a bit of an overstep and does not necessarily indicate that invoking xdg-open will fail. I am going to close this as won't fix as I don't see anything we can do from our side. Please let me know if you feel otherwise.

from go-gh.