Centralize item marshalling code into inventory. about cataclysm-dda HOT 3 CLOSED

I believe this is fixed, at least from a player standpoint.

from cataclysm-dda.

This was never specifically a player-facing bug, it's about how the code handles stuff, it impacts the player in tons of different bugs. Specifically almost any bug along the lines of "if I'm wielding x it doesn't work right", or "if X is on the ground it doesn't get handled right" are because of this problem.

I just thought of a good transitional thing to do though, we should turn player::weapon into player::weapon() {return weapon;}. Then we can push player::weapon into a special slot of the inventory (like worn items) and phase out calls to player::weapon() that don't care that the item is wielded. BOOM.

from cataclysm-dda.

This is a well known issue and does not have a proposal associated, so I'm closing it. This has mostly been implemented with the addition of a visitable infrastructure for items.

from cataclysm-dda.