Git Product home page Git Product logo

Comments (11)

panteliselef avatar panteliselef commented on June 10, 2024 2

Update: Seems like the vercel team prioritized the issue and a PR was open to address it.

As a workaround, until the fix is out, prefetch in the <Link/> needs to explicitly be set to true or false.

from javascript.

JacobJaffe avatar JacobJaffe commented on June 10, 2024

Please note that this does not occur when running in development. You'll need to build and start the server in order to reproduce this.

from javascript.

JacobJaffe avatar JacobJaffe commented on June 10, 2024

For the visual learners out there...
2024-01-06 15 34 33

from javascript.

kaksv avatar kaksv commented on June 10, 2024

I also got an error deploying on vercel Nextjs 14 but everything was perfect during development.

from javascript.

JacobJaffe avatar JacobJaffe commented on June 10, 2024

@kaksv yes, this only seems to occur during while running in dev mode. Notably, this is reproducible locally though by building and serving locally.

from javascript.

JacobJaffe avatar JacobJaffe commented on June 10, 2024

There's a worse version of this bug that occurs too. It seems that only navigating to the root page breaks, so there's scenarios like:

  1. Navigate to "/fake-page" -> 404 non-found.tsx renders
  2. Navigate from there to "/real-page" -> /real-page/page.tsx renders
  3. Navigate from there to "/" -> No navigate!

This is really bad! In practice, a 404 page being buggy is much more acceptable than a 404 page breaking a completely unrelated page

from javascript.

JacobJaffe avatar JacobJaffe commented on June 10, 2024

Any update on this?
This is really quite bad, and makes Clerk a huge risk to introduce on the App Router.

from javascript.

nikosdouvlis avatar nikosdouvlis commented on June 10, 2024

Hello @JacobJaffe :)
Just wanted to let you know that we're actively working on this. I will get back to you with more details soon.

from javascript.

panteliselef avatar panteliselef commented on June 10, 2024

Hey @JacobJaffe turns out this issue can be replicated just by using nextjs. I have created this issue in their repo. (I used the gif from this PR, I could replace it with on of ours if it bothers you.)

For some context, we are making use of headers() inside of ClerkProvider when this is mounted as a server component which causes the issue. While not ideal you can either add "use client" on top of RootLayout or for now create a custom wrapper with "use client" and only re export ClerkProvider from there.

from javascript.

JacobJaffe avatar JacobJaffe commented on June 10, 2024

@nikosdouvlis @panteliselef Thank you for the updates and for looking into this! Looking forward to the upstream fix, and thanks for relaying the workaround.

from javascript.

panteliselef avatar panteliselef commented on June 10, 2024

The fix should have landed in [email protected]

from javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.