Git Product home page Git Product logo

Comments (8)

clayrisser avatar clayrisser commented on May 28, 2024

Hmmm, the README.md already has an example. Could you direct me in how to improve it? Could you clarify what you mean by "visual" example?

from react-ast.

nitnelave avatar nitnelave commented on May 28, 2024

Hmmm, then I was mislead by the title: I feel that "render" is usually associated with creating an image from a specification, so I expected a visual representation of the AST (maybe graphviz or something like that). But you render the AST to text, which is a bit confusing.

I don't have a clear improvement in mind, but on a quick glance, the readme is a bit confusing.

from react-ast.

clayrisser avatar clayrisser commented on May 28, 2024

No it actually renders AST and optionally renders the rendered AST to text. Look at the second example.

from react-ast.

nitnelave avatar nitnelave commented on May 28, 2024

Your second example doesn't have an image, I don't see what it does:
render_ast

from react-ast.

clayrisser avatar clayrisser commented on May 28, 2024

No, there should be an AST tree there. I can paste an example but it would be huge. Maybe I'll put a small sample of the data it renders.

It's not a renderer that renders a UI. It renders an AST tree and optionally text from the AST tree. It's a bit confusing because it's a brand new concept. A concept that's only 12 hours old 😆

It is however by definition a true react renderer.

from react-ast.

nitnelave avatar nitnelave commented on May 28, 2024

I think a screenshot here would be very helpful, it's hard to grasp your 12h-old concept from just this text description :)

from react-ast.

clayrisser avatar clayrisser commented on May 28, 2024

Yeah, I definitely agree. I added a better example. I really appreciate the feedback.

Screen Shot 2019-08-29 at 10 51 23 AM

from react-ast.

clayrisser avatar clayrisser commented on May 28, 2024

You can paste the example rendered code at astexplorer.net and you will see it matches the rendered AST.

from react-ast.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.