Git Product home page Git Product logo

Comments (5)

kendallroth avatar kendallroth commented on June 15, 2024 5

While I do agree that these examples are beneficial, I would suggest that most of the examples should simply use localStorage.setItem and localStorage.getItem calls (as they are not directly documented anywhere) to reduce confusion.

from jest-localstorage-mock.

flbraun avatar flbraun commented on June 15, 2024 3

+1 to remove them from the readme. I just checked jest-localstorage-mock out for the first time in a project that doesn't even use redux and was slightly confused until I discovered this issue.
@clarkbw Would you agree to remove them if I file a PR?

from jest-localstorage-mock.

mrdulin avatar mrdulin commented on June 15, 2024 2

@clarkbw Is it necessary to introduce redux examples? I think only the basic usage needs to be given.

from jest-localstorage-mock.

clarkbw avatar clarkbw commented on June 15, 2024

Yes, that's a redux example. Should probably note that above the example.

Would you mind creating a PR to update the README?

from jest-localstorage-mock.

clarkbw avatar clarkbw commented on June 15, 2024

I think it helps show the async nature of testing.

from jest-localstorage-mock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.