Git Product home page Git Product logo

Comments (2)

groadabike avatar groadabike commented on August 19, 2024

@jonbarker68 Maybe we need to refractor HASPI and HAAQI before including HASQI?

1- In Haspi implementation, the haspi/eb,py contains several of the supporting methods
2- In Haaqi implementation, the haspi/eb,py was extended with the haaqi methods as both methods share the EarModel method.

There are common methods and methods specific to each metric.
Is it possible to group all these metrics,
For example, create evaluators/ha_metrics/*
and have:

  • ha_metrics/metrics.py
    Define haaqi, haspi and hasqi

  • ha_metrics/eb_haaqi.py

  • ha_metrics/eb_haspi.py

  • ha_metrics/eb_hasqi.py

  • ha_metrics/utils.py
    Here include the common methods

Perhaps, a better thing would be to change the HA_metrics into class with each metric extending from an abstract class but this may be a mayor change

from clarity.

jwillbailey avatar jwillbailey commented on August 19, 2024

Hi Gerado,

Is the HASQI implementation in branch 91-include-hasqi-index ready?

Will

from clarity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.