Duplicate TextEdit in textDocument/rename response about clangd HOT 4 CLOSED

It can be reproduced with the following test case:

TEST_F(ClangdVFSTest, TestRandom) {
  MockFSProvider FS;
  ErrorCheckingDiagConsumer DiagConsumer;
  MockCompilationDatabase CDB;

  ClangdServer Server(CDB, FS, DiagConsumer, ClangdServer::optsForTest());

  auto FooCpp = testPath("foo.cpp");
  Annotations Code(R"cpp(
    struct Foo{};
    Foo test() {
     F^oo x;
     return x;
    }
    )cpp");

  runAddDocument(Server, FooCpp, Code.code());

  auto X = runRename(Server, FooCpp, Code.point(), "new_name");
  ASSERT_TRUE(!!X);
  size_t PrevOffset = -1;
  for (const auto &T : X.get()) {
    EXPECT_NE(PrevOffset, T.getOffset());
    PrevOffset = T.getOffset();
  }
}

Unfortunately issue seems to be rather related to clang api we use, https://github.com/llvm/llvm-project/blob/master/clang/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp#L84

Because visitor itself returns duplicate entries for the return type of function test()

from clangd.

Another case this happens:

void foo() {
    if(auto add_xxx = 5) {
        add_xxx = 3;
    }
}

try renaming add_xxx to added_xxx(either of them results in same breakage). Which simply fails on vscode by saying "overlapping edits" and results in malformed text in vim like added_xxxxx.

from clangd.

Ycmd can cope with this as long as the old and new name have the same length, otherwise a duplicated edit does make a mess. Requesting a RefactorRename foo_bar would correctly replace the text.

from clangd.

Fixed in r360116.

from clangd.