Allow shallow-clone to a specific branch or tag about tc-build HOT 8 CLOSED

I will push it once I have a version I am happy with.

from tc-build.

So --depth=1 in git implies --single-branch (reference), which means that we only get the master branch since it is the default. We do not use the --branch parameter to git clone due to 925a800.

I can make your request work properly with the below diff but the caveat is that we are now fetching a shallow clone of all branches, which ultimately results in about 379.21 MiB being fetched, versus 125.31 MiB or so. It is up to you whether or not I push this, I do not use --shallow-clone and @kdrag0n only builds the master branch so this does not affect him. Otherwise, you can just continue to manage the repo manually if you care about the bandwidth savings.

diff --git a/build-llvm.py b/build-llvm.py
index a2e17e2..a3311fb 100755
--- a/build-llvm.py
+++ b/build-llvm.py
@@ -440,7 +440,11 @@ def fetch_llvm_binutils(root_folder, update, shallow, ref):
                                check=True,
                                cwd=cwd)
     else:
-        extra_args = ("--depth", "1") if shallow else ()
+        extra_args = ()
+        if shallow:
+            extra_args = ("--depth", "1")
+            if ref != "master":
+                extra_args += ("--no-single-branch",)
         utils.print_header("Downloading LLVM")
         subprocess.run([
             "git", "clone", *extra_args, **"git://github.com/llvm/llvm-project",**

from tc-build.

What is the output of git branch and git branch -r in llvm-project Git after your diff was applied?

I have archived today 2 tarballs with master and release/10.x Git branches of llvm-project shallow-cloned.
Means I have downloaded 2x 125MiB = 250MiB.
So 380MiB is OK for me vs. self-managed switching between these 2 tarballs.

from tc-build.

llvm-project (release/10.x) $ git branch
  master
* release/10.x
llvm-project (release/10.x) $ git branch -r
  origin/HEAD -> origin/master
  origin/master
  origin/release/1.0.x
  origin/release/1.1.x
  origin/release/1.2.x
  origin/release/1.3.x
  origin/release/1.4.x
  origin/release/1.5.x
  origin/release/1.6.x
  origin/release/1.7.x
  origin/release/1.8.x
  origin/release/1.9.x
  origin/release/10.x
  origin/release/2.0.x
  origin/release/2.1.x
  origin/release/2.2.x
  origin/release/2.3.x
  origin/release/2.4.x
  origin/release/2.5.x
  origin/release/2.6.x
  origin/release/2.7.x
  origin/release/2.8.x
  origin/release/2.9.x
  origin/release/3.0.x
  origin/release/3.1.x
  origin/release/3.2.x
  origin/release/3.3.x
  origin/release/3.4.x
  origin/release/3.5.x
  origin/release/3.6.x
  origin/release/3.7.x
  origin/release/3.8.x
  origin/release/3.9.x
  origin/release/4.x
  origin/release/5.x
  origin/release/6.x
  origin/release/7.x
  origin/release/8.x
  origin/release/9.x

This is the state of the repository after Nathan's diff was applied to a fresh clone of tc-build, and build-llvm.py invoked with ./build-llvm.py -s -b release/10.x.

from tc-build.

Cool :-).

Can you confirm the number of 380MiB data-usage from @nathanchance?

Many many thanks to both of you!

from tc-build.

Cool :-).

Can you confirm the number of 380MiB data-usage from @nathanchance?

Many many thanks to both of you!

My .git folder is 400.1MB so I guess his estimate is mostly accurate.

from tc-build.

/o\

from tc-build.

@nathanchance

Can you push this, please?
Thanks.

from tc-build.