Git Product home page Git Product logo

Comments (8)

nathanchance avatar nathanchance commented on August 15, 2024 1

Building on a phone versus building on a laptop or server are two completely different use cases. The script aims to be as quick as possible which means building with as many compile and link jobs as ninja feels is reasonable by default. The -D option is there if it needs to be lowered but I disagree with setting any value to those options by default, especially given that LLVM doesn't.

from tc-build.

nathanchance avatar nathanchance commented on August 15, 2024

There is no default value of LLVM_PARALLEL_COMPILE_JOBS or LLVM_PARALLEL_LINK_JOBS:

https://github.com/llvm/llvm-project/blob/c37dd3b6d553d7ae3afaf677f1c6abdf6b1ec74e/llvm/cmake/modules/HandleLLVMOptions.cmake#L26-L52

https://llvm.org/docs/CMake.html#llvm-specific-variables

tc-build does not touch that value. I do not know what ninja's default parallelism but they do not recommend setting a -j value so it seems like they have their own heuristic.

from tc-build.

dileks avatar dileks commented on August 15, 2024

OK, I see that commit was for custom cmake options passing to tc-build.

from tc-build.

msfjarvis avatar msfjarvis commented on August 15, 2024

I suppose this is resolved then? Closing.

from tc-build.

dileks avatar dileks commented on August 15, 2024

IMHO - not really resolved.

I rebuild with safe parallel jobs setting for compile (=2) and link (=1).
It increased my build-time from usually 03:15 to 03:25 (mm:ss) - means 10 minutes.

The initial (Chinese) reporter was building with tc-build on an embedded system and had failures.

We should be user-friendly and offer/set safe settings.

My €0,02.

from tc-build.

dileks avatar dileks commented on August 15, 2024

One question:

When I pass compile/link jobs options and do a thinlto+pgo build - is that passed to stage2 and stage3?

from tc-build.

nathanchance avatar nathanchance commented on August 15, 2024

Yes, custom values are passed to all cmake invocations.

from tc-build.

dileks avatar dileks commented on August 15, 2024

from tc-build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.