Comments (4)
I also vote for including the image in the constructor. I cannot think of any case where we need an empty object. However, having the option to change the image data later makes sense imo.
from inhomcorr.
I agree or can anyone think of a use case where an empty ImageData object would be required?
from inhomcorr.
For ImageData we decided to enforce data in the constructor.
For QMRI:
def init(self, t1=None,rho=None, ...)
(some logic)
--> you can provide maps in the constructor. If you do, the shapes will be checked. If you don't, shape will be (1,1) implicitly.
from inhomcorr.
I agree or can anyone think of a use case where an empty ImageData object would be required?
Potentially, you could have an Image object which only contains the mask from the MRData class?
from inhomcorr.
Related Issues (12)
- Design Discussion: Avoid None's HOT 3
- unknown units HOT 4
- CPU/GPU tensors HOT 3
- Missing Docstrings HOT 1
- Code Coverage HOT 1
- Tests for QMRIData
- Move BaseClasses and Interfaces into submodules
- Use tempfile to get a writeable temppath.
- Shape error in data_loader. Not caught in QMRData HOT 1
- Design discussion: avoid manual 'get' and 'set' functions
- CodeCov not working in runners. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inhomcorr.