Git Product home page Git Product logo

Comments (6)

rockycodes avatar rockycodes commented on September 22, 2024 1

@melanie-exygy this is what was settled on in the PRD (see comments here). It makes sense to me, since this is a manual process, I think it's less likely that an admin would be importing an identical program and more likely they would be importing a different program that happens to have the same admin name.

from civiform.

swatkat1 avatar swatkat1 commented on September 22, 2024 1

Yes, if an active status is not found for a give program, the code will throw an exception. If not importing the current status data, we should provide a way to create an empty status in the code.

// Create a new row in ApplicationStatuses table for the new program applicationStatusesRepository.createOrUpdateStatusDefinitions( adminName, new StatusDefinitions());

from civiform.

melanie-exygy avatar melanie-exygy commented on September 22, 2024

Couldn't we end up with a lot of duplicate programs? What about replacing the existing program if the name already exists?

from civiform.

gwendolyngoetz avatar gwendolyngoetz commented on September 22, 2024

I left a more detailed comment on the PRD. But I do see it being common that a program would be imported with the same name. Example

  • Make program on Test environment
  • Export -> Import to prod v1
  • Make changes to program on Test
  • Export -> import to prod making a v2

from civiform.

swatkat1 avatar swatkat1 commented on September 22, 2024

@rockycodes - Just letting you know we need to move the statuses data for that program from the ApplicationStatuses table too. So, if we are going with Option -1 (changing the admin name of the program, the admin name is the primary key in the statuses table. We should be changing it as well.)

from civiform.

rockycodes avatar rockycodes commented on September 22, 2024

@swatkat1 thank you for the reminder! I talked with Isabel/product a couple of weeks ago and the recommendation was to not migrate statuses for v1 of this work, but add that in for v2. Do you see any issues with ignoring statuses from a technical perspective?

from civiform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.