Git Product home page Git Product logo

Comments (4)

bunnei avatar bunnei commented on June 12, 2024

Random note: The fix for this issue might also want to address: #192 (comment)

from citra.

yuriks avatar yuriks commented on June 12, 2024

I think Archives and Files should still be separate objects, however, I think the big issue in our impl is that, for some reason, Archive implements a full File-like interface. File reading/writing operations don't belong in Archive and should be moved to File instead. Archives shouldn't be readable or writable. Another complaint I have with the current implementation is that the file ops are done via SyncRequest, and there's no good reason for this. That method is intended to dispatch behavior of the corresponding syscalls, which isn't related in this case, since users can't even pass FS service handles to that kernel function. (They're not kernel objects and they're 64-bit instead of 32-bit.) Archives and files should also not be implemented as kernel objects as they currently are, since in the real system they live in a completely separate object pool inside the FS service.

from citra.

yuriks avatar yuriks commented on June 12, 2024

This has been mostly fixed by #283. I think we can close it.

from citra.

bunnei avatar bunnei commented on June 12, 2024

Indeed. Closed.

from citra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.