REST connector: Invalid URL GET on connect to IOS-XE devices (RESTCONF) about rest HOT 3 CLOSED

As a follow up:
Based on the documentation, the connect method should not do anything:
https://pubhub.devnetcloud.com/media/rest-connector/docs/apidoc/rest.connector.libs.html#iosxe

Connecting via RESTCONF does not require contacting the device. This does nothing

In fact, the connect method sends a GET request to https://:443
So in any case, there is an inconsistence between the docstring and the actual implementation.

From my point of view, a quick win would be to remove lines 133 to 148

Furthermore a class paramter is needed for validation. If using my quick fix from above, the following line needs to be included as well in the connect method.

self.session.verify = False

It would be much cleaner to allow the user to paramterize certificate validation.
For example by adding the parameter verify=True to the connect method.

    def connect(self,
                timeout=30,
                default_content_type='json',
                verbose=False,
                port="443",
                protocol='https',
                verify=True):
    # ...
    self.session = requests.Session()
    self.session.verify = verify

from rest.

Hello @netgab ,

We are looking into this issue. Will get back soon.

from rest.

Problem solved ... code merged into master

from rest.