Comments (4)
Hi Patrick, I've been working to replicate this bug so I try and fix it but I have not been able to. Scuba will correctly flag the test as incorrect if no compliant mail flow rule is present and will mark the test as a success if any such rule exists that meets the criteria regardless of where it is.
I have tried:
- Creating a second new mail flow that is in compliance with the baseline and disabled the first rule.
- Misconfiguring the first rule and created a second mail flow rule that is compliant.
What steps did you take to find this bug?
Something incorrect I have noticed is that even if the rule is disabled, if the rule would be compliant, the test is marked as success.
from scubagear.
Give me a bit to pull the information from the customer tenant and sanitize it. Maybe you can mirror those settings and test.
There are a few checks that are doing this same thing.
from scubagear.
Something incorrect I have noticed is that even if the rule is disabled, if the rule would be compliant, the test is marked as success. ----This is what we were noticing.
from scubagear.
I have made pull request #130 where the Rego will now only examine enabled rules if they are correctly configured or not. Now for 2.7 to pass there must be at least one correctly configured rule that is enabled.
from scubagear.
Related Issues (20)
- Bug with MS.DEFENDER.2.1v1 - "User impersonation protection SHOULD be enabled for sensitive accounts in both the standard and strict preset policies." HOT 1
- Bug with MS.DEFENDER.2.2v1 - "Domain impersonation protection SHOULD be enabled for domains owned by the agency in both the standard and strict preset policies" HOT 1
- Bug with MS.DEFENDER.2.3v1 - "Domain impersonation protection SHOULD be added for important partners in both the standard and strict preset policies." HOT 1
- Defender functional tests fail due to timing/cache issues
- Defender functional test plan tests not configured correctly
- Teams product testing with ScubaGear on a GCCHIGH tenant throws a warning about 'invalid teams environment name for migration api'
- MS.SHAREPOINT.4.2v1 functional test fails in SPO mode for GCC high test tenant HOT 3
- Accessibility improvements to HTML reports
- Sharepoint 1.3 1.4 incorrectly produce Fail even when compliant under a specific condition and does not handle N/A HOT 1
- Enhance Sharepoint policy evaluation outputs for policies that are N/A under certain conditions HOT 1
- Modify Sharepoint so that the policies only execute when applicable and produce a consistent N/A message HOT 2
- MS.EXO.4.3v1 Reporting Failure / No option for config file to use other point of contact. HOT 1
- Update Repository Organization section of the readme
- Clarify that unmanaged user / skype access is not available in GCC
- Baseline Policy Enhancements, Part 1
- M365 Auditing Changes and Enhancements, Part 2 HOT 1
- Service Principal Security
- Refactor Test Cases
- Clean up sample config files
- Change from BITS to WebClient HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scubagear.