Comments (3)
Good catch. @RohanSunkarapalli Can you address?
from nwmurl.
Yes @jameshalgren , that's right. I gave that condition because when I observed the bucket we saw that the files from year 2007 doesn't have "00" appended to the date format whereas the files from 90's to 2006 has "00" at the tail of the date format.
I gave this condition -
Line 488 in a3846ba
But if you think it's not needed anymore it could be corrected by modifying the code to this way -
def generate_url_retro(date, file_type, urlbase_prefix, retrospective_var_types=None):
year_txt = date.strftime("%Y")
date_txt = date.strftime("%Y%m%d%H%M") # Updated to include minutes
if "forcing" in file_type and date.year < 2007:
url = f"{urlbase_prefix}{file_type}{year_txt}/{date_txt}.LDASIN_DOMAIN1"
elif "forcing" in file_type and date.year >= 2007:
url = f"{urlbase_prefix}{file_type}{year_txt}/{date_txt}.LDASIN_DOMAIN1"
elif "model_output" in file_type:
url = [
f"{urlbase_prefix}{file_type}{year_txt}/{date_txt}{type}"
for type in retrospective_var_types
]
if urlbase_prefix == "https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/":
for url in url:
url = url + ".json"
url = url.replace('.comp', '')
return url
from nwmurl.
Addressed by #57
from nwmurl.
Related Issues (20)
- Add post-processed NOMADs files
- Add CICD HOT 1
- Re-enable validation checker as an option and refactor as separate file and function.
- Update Readme with URL options HOT 1
- Expand to include retrospective names/urls HOT 2
- Adding options to urlbaseinput
- Remove stray notebook checkpoint folder and files HOT 1
- Limit zero padding for analysis_assim HOT 1
- Update retrospective url generaton function to include zarr s3 HOT 3
- Add 3.0 outputs HOT 1
- Remove hidden files and folders
- Retro 2.1 zarr headers bug
- Wrong URLs for retrospective NWM Retrospective dataset version 3.0
- Production deployment error
- Add tests for all potential outputs of naming HOT 2
- README's Operational dataset example does not produce valid urls
- nomads url broken
- Add output options HOT 1
- Bring the file extension (.json|.nc) into an option HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nwmurl.