Git Product home page Git Product logo

Comments (22)

ali-hm avatar ali-hm commented on June 5, 2024 11

I can too confirm, your fork @ali-hm is working just fine on Angular 16. Thank you very much, this will do it for now.

Do you plan to further maintain your fork? It's indeed a powerfull Tree-Component. All that bootstrap stuff is buggy even on their docs samples. If u dont plan to maintain the fork, which I can totally understand, I think its time to move on from this beauty 😢

I am currently using this component in my projects and I have plan to fix the issues regarding compatibility with newer versions of Angular and other dependencies. So feel free to report any issues and I will try to fix them.

from angular-tree-component.

ali-hm avatar ali-hm commented on June 5, 2024 5

Hi,
please give this fork a try:
https://github.com/ali-hm/angular-tree-component

from angular-tree-component.

slavede avatar slavede commented on June 5, 2024 4

I can confirm that @ali-hm fork is working fine. Since I have a lot of my daytime job to do, I will not continue pursuit of getting my fork to Angular 16, for the time being, I can live with @ali-hm 's solution (thanks @ali-hm btw!).

from angular-tree-component.

ali-hm avatar ali-hm commented on June 5, 2024 4

I have to create fork for angula 16:

https://www.npmjs.com/package/@docentovich/angular-tree-component

You can use my fork "@ali-hm/angular-tree-component".
It is working in Angular 14+ (Angular 14,15,16,17) without any issues. My own project (using that fork) is on Angular 17.0.8 and it works flawlessly.

from angular-tree-component.

slavede avatar slavede commented on June 5, 2024 3

Found this Fork (Seems that @slavede upgraded to Angular16 already):

Changes In Fork

https://github.com/slavede/angular-tree-component-amphinicy

Checking if it is working and will update..

Yeah, it's still work in progress. Still need to test build and publish. I plan to do that once Im back to work next week. If you are able to test build and publish feel free.
Its kind of working as an example app. Not sure completely in demo to fully test as it lacks documentation, but basic example seems to be working

from angular-tree-component.

mikila85 avatar mikila85 commented on June 5, 2024 1

Found this Fork (Seems that @slavede upgraded to Angular16 already):

Changes In Fork

https://github.com/slavede/angular-tree-component-amphinicy

Checking if it is working and will update..

from angular-tree-component.

usmananwar-1995 avatar usmananwar-1995 commented on June 5, 2024 1

@ali-hm I've updated my project to Angular 16.2.8 as well, and now the component (@ali-hm/[email protected]) works flawlessly with this version.

from angular-tree-component.

Muzummil avatar Muzummil commented on June 5, 2024 1

+1
Facing the issue with Angular 16 IVY.
@ali-hm 's fork worked fine.

from angular-tree-component.

venom977 avatar venom977 commented on June 5, 2024 1

issue not fixed yet. getting same error in angular 16.2.0

from angular-tree-component.

mycwacc avatar mycwacc commented on June 5, 2024

Thank you very much!,
We will wait for your publish.

from angular-tree-component.

odymaui avatar odymaui commented on June 5, 2024

I saw this post, #951, and am assuming to get this to v16, it's do it yourself as there don't appear to be any alternatives. If someone has already done it, please let me know so I can stop working on this:).

I am working on an ng upgrade project that uses the tree component. I was able to get my project to ng v15 with the existing component but was blocked on moving to v16.

Update: I have made changes to build, pass all tests and publish to NPM as well and run in a new ng v16 solution.

I have limited time, knowledge etc, but if you need to get it working, it is an option now.

https://github.com/odymaui/angular-tree-component/tree/angular-upgrades-11-to-16

from angular-tree-component.

odymaui avatar odymaui commented on June 5, 2024

Unfortunately it looks like you are only at version 14. Have you tried upgrading all the way to version 16?

from angular-tree-component.

ali-hm avatar ali-hm commented on June 5, 2024

There is no need to upgrade it to 16 right now, It is compiled using Ivy and the error "TreeModule is not compatible with Angular Ivy" has been resolved. You can use it in Angular 14+.

from angular-tree-component.

avoronkoff avatar avoronkoff commented on June 5, 2024

@slavede Hi, man! Did you publish this library on NPM, already?

from angular-tree-component.

slavede avatar slavede commented on June 5, 2024

@slavede Hi, man! Did you publish this library on NPM, already?

Hey, check the comment above. ali-hm's project solves Ivy issue so I did not continue with updating my fork to 16

from angular-tree-component.

odymaui avatar odymaui commented on June 5, 2024

@avoronkoff - If you need a fork/package that requires ngcc, use one of the forks mentioned above.

If you require a fork/package that does not require/depend on ngcc, you can try this https://www.npmjs.com/package/@odymaui/angular-tree-component.

Support is limited but it is an option if you need to move to Ivy only.

from angular-tree-component.

AriPapari avatar AriPapari commented on June 5, 2024

I can too confirm, your fork @ali-hm is working just fine on Angular 16. Thank you very much, this will do it for now.

Do you plan to further maintain your fork? It's indeed a powerfull Tree-Component. All that bootstrap stuff is buggy even on their docs samples. If u dont plan to maintain the fork, which I can totally understand, I think its time to move on from this beauty 😢

from angular-tree-component.

AriPapari avatar AriPapari commented on June 5, 2024

I am currently using this component in my projects and I have plan to fix the issues regarding compatibility with newer versions of Angular and other dependencies. So feel free to report any issues and I will try to fix them.

Thats really nice too hear. Much appreciated, thank you!

from angular-tree-component.

liesahead avatar liesahead commented on June 5, 2024

@tobiasengelhardt

from angular-tree-component.

usmananwar-1995 avatar usmananwar-1995 commented on June 5, 2024

@ali-hm solution is not working correctly with Angular 16. When I attempt to use it, I encounter a dependency conflict error with Angular Core versions. Specifically, the package seems to be designed for Angular 14+, but it's not compatible with Angular 16 due to changes in core dependencies.

Here is an extract of the version conflict:

Found: @angular/[email protected]
@angular/core@"^16.2.6" from the root project
peer @angular/core@">=14.0.0" from @ali-hm/[email protected]
@ali-hm/angular-tree-component@"^12.0.5" from the root project
Could not resolve dependency

from angular-tree-component.

ali-hm avatar ali-hm commented on June 5, 2024

@usmananwar-1995 currently I am using this component (my version:12.0.5) in Angular 16.2.8 and it has no issue (building like a charm). please make sure the issue is not related to other aspects of your project.

from angular-tree-component.

docentovich avatar docentovich commented on June 5, 2024

I created a fork with support for version 16:

https://www.npmjs.com/package/@docentovich/angular-tree-component

from angular-tree-component.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.