Git Product home page Git Product logo

Comments (11)

ds58 avatar ds58 commented on August 24, 2024

I am working on a new project which supports this feature

New projects are located here under "CinemaMod" https://github.com/CinemaMod

from mcef.

Garulf avatar Garulf commented on August 24, 2024

I am very interested in getting codec support for my MCEF. Is there a guide or reference on how to achieve this?

from mcef.

ds58 avatar ds58 commented on August 24, 2024

I am very interested in getting codec support for my MCEF. Is there a guide or reference on how to achieve this?

There's several things to consider:

If you are new to CEF/Chromium, you should know that, by distributing a version of CEF built with proprietary codecs, you are required to have licenses for those codecs.

My new project, CinemaMod, gets around this by not distributing the CEF-with-proprietary-codecs binaries directly, but rather, I distribute the normal CEF binaries without codecs and in addition include bsdiff patch files which contain binary diffs between the 2 CEF versions: CEF-with-codecs and CEF-without-codecs. The process for me is basically:

  1. Build CEF+JCEF without codecs
  2. Build CEF+JCEF with codecs
  3. Take a bsdiff between the 2 sets of binaries
  4. Create manifest files (list of binaries + hashes) for each build (JCEF-w-codecs, JCEF-wo-codecs, the bsdiff files)
  5. Upload the manifest files for each build, upload JCEF without codecs, upload the bsdiff binaries all to my S3 bucket in a structured way
cinemamod-libraries/
  jcef/
    4896/
      linux64/
        manifest.txt
        libcef.so
        libjcef.so
        ...
      win64/
        manifest.txt
        libcef.dll
        libjcef.dll
        ...
  jcef-patches/
    4896/
      linux64/
        manifest.txt
        patched-manifest.txt
        libcef.so.diff
      win64/
        manifest.txt
        patched-manifest.txt
        libcef.dll.diff
        libEGL.dll.diff
        chrome_elf.dll.diff
        ...

(As you may notice, I have support for Windows x86_64 and Linux x86_64 at the moment. I don't have a working macOS build yet.)

I'm not sure how technical you want to get, I just thought I would describe my process for context. It would be possible to use my "downloader/patcher" system from CinemaMod in MCEF if you wanted to utilize my newer JCEF builds with codec patches. The process for that in the code is basically:

  1. When MC launches, check the disk to see if we have JCEF installed in the CinemaMod libraries path
  2. If not installed, download JCEF without codecs
  3. Download the codec bsdiff patch files
  4. Apply the patches to the JCEF build without codecs

See this package for an example of how that's all done: https://github.com/CinemaMod/CinemaMod-Fabric/tree/master/src/main/java/com/cinemamod/downloader

from mcef.

ds58 avatar ds58 commented on August 24, 2024

My new project, CinemaMod, gets around this

This is also a legally gray area for sure. I'm not a lawyer so don't take this as fact.

from mcef.

Garulf avatar Garulf commented on August 24, 2024

Thank you very much for responding! I am looking into getting this to work on my end.

from mcef.

Garulf avatar Garulf commented on August 24, 2024

image

It works beautifully thanks again!

I can watch a 4k movie from my Plex server in Minecraft!

from mcef.

ds58 avatar ds58 commented on August 24, 2024

It works beautifully thanks again!

Glad you got it to work. It would probably be possible to get a plex player working in CinemaMod so that you have additional features such as: multiplayer video sync, video queue/skip/vote skip, video timeline as a boss bar, regional theater boundaries defined by WorldGuard regions, and other stuff as well

from mcef.

Garulf avatar Garulf commented on August 24, 2024

It works beautifully thanks again!

Glad you got it to work. It would probably be possible to get a plex player working in CinemaMod so that you have additional features such as: multiplayer video sync, video queue/skip/vote skip, video timeline as a boss bar, regional theater boundaries defined by WorldGuard regions, and other stuff as well

I'd love to use your CinemaMod but I'm stuck on a long term build using 1.12 atm. Multiplayer video sync would be amazing!

from mcef.

memesaregood1 avatar memesaregood1 commented on August 24, 2024

I am very interested in getting codec support for my MCEF. Is there a guide or reference on how to achieve this?

There's several things to consider:

If you are new to CEF/Chromium, you should know that, by distributing a version of CEF built with proprietary codecs, you are required to have licenses for those codecs.

My new project, CinemaMod, gets around this by not distributing the CEF-with-proprietary-codecs binaries directly, but rather, I distribute the normal CEF binaries without codecs and in addition include bsdiff patch files which contain binary diffs between the 2 CEF versions: CEF-with-codecs and CEF-without-codecs. The process for me is basically:

  1. Build CEF+JCEF without codecs
  2. Build CEF+JCEF with codecs
  3. Take a bsdiff between the 2 sets of binaries
  4. Create manifest files (list of binaries + hashes) for each build (JCEF-w-codecs, JCEF-wo-codecs, the bsdiff files)
  5. Upload the manifest files for each build, upload JCEF without codecs, upload the bsdiff binaries all to my S3 bucket in a structured way
cinemamod-libraries/
  jcef/
    4896/
      linux64/
        manifest.txt
        libcef.so
        libjcef.so
        ...
      win64/
        manifest.txt
        libcef.dll
        libjcef.dll
        ...
  jcef-patches/
    4896/
      linux64/
        manifest.txt
        patched-manifest.txt
        libcef.so.diff
      win64/
        manifest.txt
        patched-manifest.txt
        libcef.dll.diff
        libEGL.dll.diff
        chrome_elf.dll.diff
        ...

(As you may notice, I have support for Windows x86_64 and Linux x86_64 at the moment. I don't have a working macOS build yet.)

I'm not sure how technical you want to get, I just thought I would describe my process for context. It would be possible to use my "downloader/patcher" system from CinemaMod in MCEF if you wanted to utilize my newer JCEF builds with codec patches. The process for that in the code is basically:

  1. When MC launches, check the disk to see if we have JCEF installed in the CinemaMod libraries path
  2. If not installed, download JCEF without codecs
  3. Download the codec bsdiff patch files
  4. Apply the patches to the JCEF build without codecs

See this package for an example of how that's all done: https://github.com/CinemaMod/CinemaMod-Fabric/tree/master/src/main/java/com/cinemamod/downloader

necroing, but the links are now dead. is there a new way? I am using Mysticpasta1's MCEF fork.

from mcef.

JonnygamingTv avatar JonnygamingTv commented on August 24, 2024

Hope this may be added soon :)
In the meanwhile, .webm seem to work 👍

from mcef.

ds58 avatar ds58 commented on August 24, 2024

This issue is now irrelevant with MCEF 2.x. The binaries that are included contain the codecs

from mcef.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.