Comments (1)
Changing the names of local variables is fine with me, if it makes the code easier to follow. Reusing work arrays was originally to minimize memory use but we can hardly claim to be efficient with that anymore.
intent(inout) was used to prevent an extra copy when passing arguments in and out of subroutines, and so was used throughout the code for this small bit of computational efficiency gain. For some reason, intent(out) did an extra copy that (inout) didn't have to do. I'm not sure whether this is still an issue with newer compilers. The tradeoff, of course, is some confusion about whether the variable actually needs to be passed in. I used it as a convenient excuse for gathering initializations into one code block in a higher routine.
from icepack.
Related Issues (20)
- closing/flushing nu_diag at end HOT 4
- Check consistency of snow-transition parameter documentation HOT 2
- timeseries plots in conda environment HOT 13
- documentation for calc_dragio and formdrag options HOT 2
- Index error in bgc tracer for shortwave calculations HOT 6
- Add support for disabling thermodynamics HOT 2
- investigate impacts of advanced snow physics HOT 6
- bug in icedrv_history.F90 regarding trcrn HOT 1
- FSD documentation
- Minus sign missing in snow loss equation
- Deprecate zsalinity HOT 8
- snow depth bug when running with one snow layer and advanced snow physics
- kice in mushy thermodynamics HOT 1
- Bug in init_vertical_profile for BL99 thermodynamics HOT 1
- tice_high in init_vertical_profile for ktherm = 2 HOT 2
- Meltpond advection equation HOT 4
- Tmax in icepack_itd code HOT 7
- Correct qsno units in comments
- Inconsistent units in zap_snow_temperature HOT 2
- calc_dragio functionality HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from icepack.