Parcelize serializable data is broken about serialization-parcelable HOT 5 CLOSED

Resolved with release 0.6.0 (10): https://github.com/chRyNaN/serialization-parcelable/releases/tag/0.6.0

from serialization-parcelable.

Welcome and thanks for contributing! Make sure to leave a detailed explanation of the issue.

from serialization-parcelable.

I was able to reproduce the issue. I'm not positive about the cause, but it seemed to be an incorrect function call. It was resolved after the changes made in the following commit where I removed the AndroidParceler class: 92fd90c. I will try and write some tests to make sure that this issue doesn't occur again. The fix will be released in the next version.

from serialization-parcelable.

The issue has to do with the Parcel(ByteArray) constructor function implementation for the Android target. The decodeFromParcel function was updated previously to get the parcel.toByteArray() from the parcel parameter and create a new Parcel using that constructor function. Then that Parcel was decoded with a ParcelDecoder. This was added to help some issue with the ByteArrayParcel implementation for other platforms, but it seems that it broke the Android usage. I will investigate further and ensure that both implementations work.

from serialization-parcelable.

The issue had to do with the Android implementation of the Parcel(ByteArray) calling setDataPosition(0) and the above mentioned use of creating a new Parcel from the provided parcel in the Parcelable.decodeFromParcel function. The Parcelable.encodeToBundle/Parcelable.decodeFromBundle have to internally manage a size and magic numbers set inside the android.os.Parcel class. Because of this, the size should have been set to 8 (two four byte int values were set). Instead of hardcoding this, since it is TBD which component should be responsible for setting that, I think removing the wrapper creation of a new parcel in the decodeFromParcel function is the solution and seems to work. However, we should be on the lookout for issues on other Kotlin targets.

from serialization-parcelable.