replace Communication\Connection::waitForDelay's usleep with select about chrome HOT 7 OPEN

Is this basically what you had in mind as the only change?

from chrome.

OK, I can make the change then. I just didn't want to be treading on toes. ;)

from chrome.

For this to be fixed, \Wrench\Client needs a getSocketResource() method.

Made a PR: chrome-php/wrench#17

Before more progress can be made, it seems we need to wait for the method/PR to be accepted, and wait for a new chrome-php/wrench version to be released 🤔

Here is my investigation notes so far:
class \HeadlessChromium\Communication\Connection has a protected \HeadlessChromium\Communication\Socket\SocketInterface $wsClient;

\HeadlessChromium\Communication\Socket\SocketInterface has no getSocketResource().

\HeadlessChromium\Communication\Socket\Wrench must then create its own getSocketResource(),
returning the resource from protected \Wrench\Client $client;
\Wrench\Client needs a getSocketResource(), returning it's socket resource from protected \Wrench\Socket\ClientSocket $socket;

\Wrench\Socket\ClientSocket inherits $this->socket property from UriSocket...

\Wrench\Socket\UriSocket inherits $this->socket property from \Wrench\Socket\AbstractSocket...

\Wrench\Socket\AbstractSocket has a public function getResource()

that means UriSocket has it too... that means ClientSocket also has it.. \Wrench\Client needs to expose it publicly (or at least protectedly)
it needs a
public function getSocketResource(){return $this->socket->getResource();}

from chrome.

update: The upcoming Wrench 1.7 will have a new \Wrench\Client::waitForData method which uses select() internally, we should replace \usleep($timeToWait * 1000); with $this->wsClient->waitForData($timeToWait); once Wrench >=1.7 is available.

from chrome.

@divinity76 Are you planning on picking up the next step of this, with a PR to this repo?

from chrome.

@GrahamCampbell no, I've since lost interest, I made some workaround for my specific problem and moved on.

But yes that's exactly what I had in mind!

from chrome.

@GrahamCampbell perfect, thanks

from chrome.