Git Product home page Git Product logo

Comments (6)

ChrisTrenkamp avatar ChrisTrenkamp commented on August 20, 2024

I can see why one would want access to the lexer, but you sure you want access to the parser? The parse tree is built in a very particular way so the evaluator can do its job, and if goxpath's evaluator isn't behaving the way you want, building another evaluator around goxpath's parse tree probably won't do you any good.

Also, can you explain where you're seeing some performance issues in goxpath?

from goxpath.

rski avatar rski commented on August 20, 2024

The performance issues are because I don't evaluate it on XML exactly, so most of the functions in findUtils are really expensive. On the other hand, I can take some shortcuts that aren't available in XML.

The parse tree is built in a very particular way so the evaluator can do its job, and if goxpath's evaluator isn't behaving the way you want, building another evaluator around goxpath's parse tree probably won't do you any good.

Until now I haven't faced anything like this, benchmarks are looking quite good. It sounds like there is something specific you have in mind wrt any design decisions in the evaluator though, which I might not have hit yet.

from goxpath.

ChrisTrenkamp avatar ChrisTrenkamp commented on August 20, 2024

Can you point to which parts in the lexer/parser packages you need? It's probably not as simple as just getting rid of the internal part; a lot of methods and fields are private because they weren't really designed with a public API in mind.

from goxpath.

rski avatar rski commented on August 20, 2024

For now, I'm using pretty much everything the current evaluator is using, only in a different way. You can have a look at the changes i've made at https://github.com/aristanetworks/goxpath/commits/master

from goxpath.

ChrisTrenkamp avatar ChrisTrenkamp commented on August 20, 2024

Your changes look good. Pulling them down.

from goxpath.

rski avatar rski commented on August 20, 2024

excellent, thanks a lot!

from goxpath.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.