Git Product home page Git Product logo

Comments (8)

bielik01 avatar bielik01 commented on August 22, 2024 1

Yeah, I just noticed what that package does, it's pure magic! But even then, I kinda want it to have name specified by me 😂

from refitter.

christianhelle avatar christianhelle commented on August 22, 2024 1

@bielik01 This is implemented but not thoroughly tested yet. I'm taking a few days off for the autumn break to spend some time with the family

from refitter.

christianhelle avatar christianhelle commented on August 22, 2024

@bielik01 thanks for taking the time to report this

The .g.cs output file was a remnant of the initial source generator implementation. In the original implementation, which didn't work, the output file was never persisted to disk (the normal behavior for source generators). Unfortunately, source generators ran independently of each other and the Refit source generator didn't know that Refitter generated a Refit interface

I'll fix this by adding the outputFileName that you suggest

from refitter.

christianhelle avatar christianhelle commented on August 22, 2024

@all-contributors please add @bielik01 for bugs

from refitter.

allcontributors avatar allcontributors commented on August 22, 2024

@christianhelle

I've put up a pull request to add @bielik01! 🎉

from refitter.

bielik01 avatar bielik01 commented on August 22, 2024

Thanks a lot! I try to keep files in the project to minimum 😅

from refitter.

christianhelle avatar christianhelle commented on August 22, 2024

@bielik01 Do you use the Refitter.SourceGenerator package reference? This does some MSBuild magic that automagically includes any .refitter file as AdditionalFiles which allows the Refitter source generator to discover it upon build time, generating the .g.cs file. There wouldn't be a need to use the CLI tool if you're already using the source generator

Thanks a lot! I try to keep files in the project to minimum 😅

Perfectly understandable, I do the same. No code is better and faster than no code :)

from refitter.

christianhelle avatar christianhelle commented on August 22, 2024

I'll try to implement this tonight

from refitter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.