Comments (5)
christianhelle
commented on August 22, 2024
1
@all-contributors please add @waylonmtz for bugs
from refitter.
waylonmtz
commented on August 22, 2024
I even tried to set the schema.default to null but this still did not cause refitter to generate a method signature with default nulls.
re: IsPrimary
from refitter.
christianhelle
commented on August 22, 2024
@waylonmtz Thanks for taking the time to report this.
I'll see what I can do. I'm AFK most of this weekend, so I'll probably look into this on Monday.
Do you mind sharing the full OpenAPI doc? It would be more convenient for me to test things out
from refitter.
christianhelle
commented on August 22, 2024
I re-formatted the spec you provided and it seems to have enough information for to troubleshoot the problem in detail
"/v1/accounts/{accountId}/addresses": {
"get": {
"tags": [
"AccountAddresses"
],
"operationId": "AccountAddresses_GetAccountAddresses",
"parameters": [
{
"name": "accountId",
"in": "path",
"required": true,
"schema": {
"type": "integer",
"format": "int64"
},
"x-position": 1
},
{
"name": "IsPrimary",
"in": "query",
"schema": {
"type": "boolean",
"nullable": true,
"default": null
}
},
{
"name": "IsActive",
"in": "query",
"schema": {
"type": "boolean",
"nullable": true
}
},
{
"name": "IncludeSpouse",
"in": "query",
"schema": {
"type": "boolean"
}
},
{
"name": "SortBy",
"in": "query",
"style": "form",
"explode": true,
"schema": {
"type": "array",
"nullable": true,
"xml": {
"name": "ArrayOfstring",
"wrapped": true
},
"items": {
"type": "string",
"xml": {
"name": "string"
}
}
}
},
{
"name": "Search",
"in": "query",
"schema": {
"type": "string",
"nullable": true
}
},
{
"name": "PageNumber",
"in": "query",
"schema": {
"type": "integer",
"format": "int32"
}
},
{
"name": "PageSize",
"in": "query",
"schema": {
"type": "integer",
"format": "int32"
}
},
{
"name": "ExportFileName",
"in": "query",
"schema": {
"type": "string",
"nullable": true
}
}
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/PagedApiResponseOfIEnumerableOfAccountAddressSummary"
}
}
}
}
}
},
"post": {
"tags": [
"AccountAddresses"
],
"operationId": "AccountAddresses_CreateAccountAddress",
"parameters": [
{
"name": "accountId",
"in": "path",
"required": true,
"schema": {
"type": "integer",
"format": "int64"
},
"x-position": 1
}
],
"requestBody": {
"x-name": "command",
"content": {
"application/json": {
"schema": {
"nullable": true,
"$ref": "#/components/schemas/CreateAccountAddress"
}
}
},
"x-position": 2
},
"responses": {
"201": {
"description": "",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/AccountAddressSummary"
}
}
}
}
}
}
}from refitter.
allcontributors
commented on August 22, 2024
I've put up a pull request to add @waylonmtz! 🎉
from refitter.
Related Issues (20)
- Add support for old core frameworks versions from .net6 HOT 5
- More than one generated Client Api will result in an Extension Method Conflict for ConfigureRefitClients HOT 6
- IAsyncEnumerable - JSONL/application/x-ndjson HOT 7
- Hyphens with JsonStringEnumConverter results in `JSON value could not be converted` HOT 7
- Response is always nullable under `generateNullableReferenceTypes` HOT 2
- Source generator does not work in .Net 8 HOT 1
- Support for OpenAPI version 3.1.0 HOT 2
- Non string/boolean CodeGeneratorSettings are not honored HOT 3
- Generate the client from multiple versions HOT 1
- `remove-unused-schema` not working for collection-type responses HOT 1
- Asana API "cannot derive from sealed type" HOT 4
- Code Generator creates unsafe interface method names HOT 1
- Code Generator adds numeric suffix to Interface method name when not needed HOT 3
- Add the facility to exclude namespaces from generated code HOT 5
- Asana API specs strange naming HOT 2
- Refit Fails on Jira OpenAPI specs HOT 5
- Serializer improvements HOT 1
- All Contributors Bot HOT 12
- Polly.Extensions.Http deprecated in favour of Microsoft.Extensions.Http.Resilience HOT 3
- Support generating immutable records HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from refitter.