Parameters' casing in openAPI document are not honoured in Refit interface methods about refitter HOT 5 CLOSED

I just experimented a bit with the Swagger Petstore v3 example

$  curl -X 'POST' 'https://petstore3.swagger.io/api/v3/pet/1?NaMe=Velociraptor&StAtUS=Available'

returns

No name provided

I tried it out in Refit and can see that using [AliasAs()] in the interface works

[Get("/pet/{petId}")]
Task<Pet> GetPetById(long petId);

[Post("/pet/{petId}")]
Task UpdatePetWithForm(
    long petId, 
    [AliasAs("name")][Query] string nAmE, 
    [AliasAs("status")][Query] string StAtUS);

in this example

var client = RestService.For<ISwaggerPetstoreOpenAPI30>("https://petstore3.swagger.io/api/v3");

var pet = await client.GetPetById(1);

Console.WriteLine($"Name: {pet.Name}");

await client.UpdatePetWithForm(
    petId: pet.Id,
    nAmE: $"{pet.Name} Updated",
    StAtUS: Status.Available.ToString());

pet = await client.GetPetById(1);

Console.WriteLine($"New Name: {pet.Name}");

outputs:

Name: Velociraptor
New Name: Velociraptor Updated

I suggest that we keep the "code friendly" camelCase style parameter naming and use [AliasAs()] to specify what the spec says the parameter should be called.

What do you think @guillaumeserale ?

from refitter.

@christianhelle yes, I agree; using [AliasAs()] seems the proper way to do it. I suggest it should be added only if the parameter name name and spec name nAmE differ.

from refitter.

Apparently the code was already there, I just had to make sure it respected the original casing

from refitter.

@guillaumeserale thanks for reporting this! I'll look into this tonight

from refitter.

@guillaumeserale my thoughts exactly. No need to use [AliasAs()] if the parameter name the same

from refitter.