Git Product home page Git Product logo

Comments (7)

christianalfoni avatar christianalfoni commented on August 23, 2024

Jup, sure, I am not really doing anything special with this lib so it should not be a problem. I will check it out and make an update :-)

from flux-angular.

sheerun avatar sheerun commented on August 23, 2024

By the way: I'm pretty sure bundling all your released in source is bad idea.

There should be only one file: build/flux-angular.js. You don't even need minification.

Disclaimer: I'm bower maintainer :D

from flux-angular.

sheerun avatar sheerun commented on August 23, 2024

For the reason: people should not need to change path in RequireJS configuration when they update your component. Also main in bower.json should point to already built (but not minified) file.

from flux-angular.

sheerun avatar sheerun commented on August 23, 2024

All to all, three fixes:

  1. Angular version to ~1.2
  2. main in bower.json to build/flux-angular.js
  3. Remove releases director from repository, until not too many people depend on them.

Cheers!

from flux-angular.

sheerun avatar sheerun commented on August 23, 2024

Oh, and you don't need to include angular.js in repository (even not recommended).

from flux-angular.

christianalfoni avatar christianalfoni commented on August 23, 2024

Haha, thanks for all your input, this is great :-)

I will do the fixes you recommend here. Angular.js was just put in there for testing, but no need to commit it of course. I have a couple of other projects set up this way too, so I need to fix them also.

from flux-angular.

sheerun avatar sheerun commented on August 23, 2024

You can always use angular from bower_components or node_modules.

On Tue, Nov 25, 2014 at 12:08 PM, Christian Alfoni <[email protected]

wrote:

Haha, thanks for all your input, this is great :-)

I will do the fixes you recommend here. Angular.js was just put in there
for testing, but no need to commit it of course. I have a couple of other
projects set up this way too, so I need to fix them also.


Reply to this email directly or view it on GitHub
#3 (comment)
.

from flux-angular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.