Git Product home page Git Product logo

Comments (14)

ChrisRM avatar ChrisRM commented on July 23, 2024

Are you talking about the color in the gutter? and yeah, it should install a new UI theme, not just the scheme.

from material-theme-jetbrains.

ProjectInfinity avatar ProjectInfinity commented on July 23, 2024

Yes, that indicates changed/new lines when you have a git-enabled project.

from material-theme-jetbrains.

ChrisRM avatar ChrisRM commented on July 23, 2024

I'll fix that.

from material-theme-jetbrains.

ProjectInfinity avatar ProjectInfinity commented on July 23, 2024

Missed out that you said it should install a theme. It did not for me. Only the scheme, running Windows 10 with JDK 1.8, all 64bit.

from material-theme-jetbrains.

Cosmicist avatar Cosmicist commented on July 23, 2024

This is just a configuration issue, the colors are way to subtle but can easily be changed in the config. What I do see as a problem is that I even though I can create a custom theme using the "save as..." feature, PhpStorm won't use that one in favor of the one in the plugin the next time I open it.

from material-theme-jetbrains.

ProjectInfinity avatar ProjectInfinity commented on July 23, 2024

@xFlatlinex Explain how this is a configuration issue? I just proved in the last two images that it's broken.

Removing the first comment marks the next lines as altered, even though ALL of them should have been marked as altered. This does not happen on default Darcula.

from material-theme-jetbrains.

Cosmicist avatar Cosmicist commented on July 23, 2024

@ProjectInfinity I re-read your first message because I thought you were referring just to the color. The issue you mention is not happening to me, or at least I didn't notice it yet.

from material-theme-jetbrains.

ProjectInfinity avatar ProjectInfinity commented on July 23, 2024

@xFlatlinex If you look at the images there are no changed lines marked when using Material. The one you can see is actually new lines and not altered. It's a bit confusing maybe, but yes. Definitely not a case of too subtle colors. :)

from material-theme-jetbrains.

Cosmicist avatar Cosmicist commented on July 23, 2024

@ProjectInfinity hehe yea, got it now, thanks for the clarification.

But I still think this is a configuration issue, let me explain:

When I edit a line, it looks like it doesn't mark it in the gutter, but it actually does, albeit invisible, because if you check Gutter > Modified lines the background is disabled in this theme:

gutter-modified-lines-color

But if I modify that by setting a background color for it:

gutter-modified-lines-color-set

The color in the gutter shows up just fine:

gutter-modified-added-lines

Notice I modified both colors and I had to save the modifications to a copy of the theme since it doesn't let me modify the one in the plugin. Which, BTW, leads to another issue #20.

from material-theme-jetbrains.

ChrisRM avatar ChrisRM commented on July 23, 2024

Fixed in the newest build

from material-theme-jetbrains.

ProjectInfinity avatar ProjectInfinity commented on July 23, 2024

Wasn't this supposed to create a theme? It still doesn't.

Not to mention that the issue still does not appear fixed when reinstalling the latest release. I had to create my own scheme and do the fix that @xFlatlinex specified.

from material-theme-jetbrains.

ChrisRM avatar ChrisRM commented on July 23, 2024

Indeed it should. I'm on it

from material-theme-jetbrains.

ChrisRM avatar ChrisRM commented on July 23, 2024

@ProjectInfinity What IDE and version are you on using?

from material-theme-jetbrains.

ProjectInfinity avatar ProjectInfinity commented on July 23, 2024

@ChrisRM PhpStorm 9.0.2 141.2462

from material-theme-jetbrains.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.