Inline snippets not rendering about ember-freestyle HOT 15 CLOSED

Thanks Chris. I'll try to test out this change today!

Ryan Sonnek
[email protected]

On Apr 20, 2016, at 11:12 AM, Chris LoPresto [email protected] wrote:

@wireframe https://github.com/wireframe Let me know if this resolves things for you.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #30 (comment)

from ember-freestyle.

@chrislopresto v0.2.12 fixes my issue. Thanks!

from ember-freestyle.

@wireframe I'm happy to help out and see what's going on, but I'll need some details. Can you copy/paste code samples or share links to a public gist or repository?

from ember-freestyle.

I'll do my best to create a simple testcase. My guess at the moment is that it may have something to do with organizing my components into pods?

I'm using the ember-component-css addon which requires pods at the moment.

from ember-freestyle.

You may need to specify snippetSearchPaths like this:

By default, ember-freestyle looks in app. I obviously need to document this!

from ember-freestyle.

FYI, the technique comes from https://github.com/ef4/ember-code-snippet

from ember-freestyle.

@wireframe Let me know if this resolves things for you.

from ember-freestyle.

Unfortunately, No :dice: using this approach. It could easily be user error, but I've been unable to trace down the root cause of this issue.

I'm going to have to table this issue for the time being, and you can feel free to close out this issue until I have time to revisit it further.

from ember-freestyle.

@wireframe Is you freestyle.hbs shareable? I'm using a pod structure as well with ember-component-css and I'm just about to setup everything. I could try your setting on the way and figure out what setting you need to set.

from ember-freestyle.

I would suggest we add some sane defaults for the snippet path based on the usePods flag.

snippetSearchPaths for pod structure: ['tests/dummy/app', 'app']
snippetSearchPaths for normal structure: ['tests/dummy/app/styles', 'app/styles']

from ember-freestyle.

I think I am having a similar issue. I found that inline snippets in my scss files are not found, but if I put them in a js file (like the freestyle.js controller) then they are found.

The scss files are in the app folder, so I believe they should be in the snippetSearchPaths by default.

The example snippet that works in js but not scss is:

/* BEGIN-FREESTYLE-USAGE modules-buttons-normal:notes

Use these whenever you need some kind of clickable surface to afford an action that
isn't a boring, inconspicuous text link.

END-FREESTYLE-USAGE */

from ember-freestyle.

@Niltz I just realized that I never wired up SCSS notes snippets. #63 will do the trick. I'll merge it and cut a new release.

from ember-freestyle.

FYI, this whole setup needs to be cleaned up. I think these are the two next issues to focus on:

• Simplify Technique for Including Notes #61
• Support different FREESTYLE-USAGE-* code snippet delimiters #48

from ember-freestyle.

@Niltz I just published v0.2.12, which supports SCSS note snippets. You can see it in action here:

Source

/* BEGIN-FREESTYLE-USAGE fpi:notes
# Markdown Notes In SCSS!

Hey look... these are `markdown` notes:

- coming from scss
- looking nice

END-FREESTYLE-USAGE */

Rendered
http://chrislopresto.github.io/ember-freestyle/?f=fpi&m=false&s=Visual%20Style&ss=Color

from ember-freestyle.

@wireframe I'm going to close this for now. Feel free to reopen or open a new issue if your problem persists.

from ember-freestyle.