Git Product home page Git Product logo

Comments (5)

maxigaz avatar maxigaz commented on July 21, 2024

Looking at this part of the code tells me nvim-spider relies on regular Lua string patterns such as %u for uppercase letters.

To my knowledge, the reason accented letters are ignored in such patterns is because Neovim relies on LuaJIT, which is based on Lua 5.1, which doesn't support the UTF8 character set (unlike later versions of Lua).

One option could be to rewrite that part of the code in order to use the external library utf8, and distribute the library with the plugin. I'm not very familiar with plugin development at this point, so I'm not sure if this would be the 'right' way of doing it though.

from nvim-spider.

chrisgrieser avatar chrisgrieser commented on July 21, 2024

good find. yeah, I assume that adding some library like that would be necessary. however, I am a bit short on time for the next couple of weeks, so feel free to submit a PR if you figure it out?

from nvim-spider.

JarKz avatar JarKz commented on July 21, 2024

Hello and welcome!

I tried to make it, found some libraries that do it, but need to understand some things. First, I found the useful C library in github, which can be compiled by luarocks: starwing/luautf8.
But, as you know, it's not simple to add non-plugin for neovim lua library. That's make some complexity to install but I also find these things:

  1. packer.nvim already have some functionality that installs non-plugin for neovim lua library (keyword use_rocks);
  2. if user don't use the packer.nvim then he can install plugin theHamsta/nvim_rocks that also do.
    In the second case, need put some code in dependencies. For example, in lazy.nvim:
return {
	"chrisgrieser/nvim-spider",
	dependencies = {
		"starwing/luautf8",
		{
			"theHamsta/nvim_rocks",
			event = "VeryLazy",
			build = "pip3 install --user hererocks && python3 -mhererocks . -j2.1.0-beta3 -r3.0.0 && cp nvim_rocks.lua lua",
			config = function()
				local rocks = require("nvim_rocks")
				rocks.ensure_installed("luautf8")
			end,
		},
	},
}

Finally, I've writed code for me and I've found nuances. col indexing will be deprecated in the method getNextPosition and firstMatchAfter because UTF-8 contains bytes that have different widths and need use offset instead of this. As you see, need rewrite some code. I don't know how you feel about this, so I'd like to know what you think about it, @chrisgrieser?

from nvim-spider.

backdround avatar backdround commented on July 21, 2024

I've reimplemented the plugin and fixed the issue as well. neowords.nvim

from nvim-spider.

chrisgrieser avatar chrisgrieser commented on July 21, 2024

added in the latest release, see readme for adding the required luarocks dependency for it

from nvim-spider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.