Git Product home page Git Product logo

Comments (4)

chrisgervang avatar chrisgervang commented on May 24, 2024

For now, I don't want to convert to yarn or remove typescript code paths until we've got a stable release out. The original package had a build system in place that used npm, since it works and bazel is set up already - I'd prefer not to change it (instead prioritizing new features).

from flowtype-protoc-gen.

shanshanzhu avatar shanshanzhu commented on May 24, 2024

Sure. agree with the priority. I move remove typescript specific code path and yarn to other tasks.

For yarn and the build system: it depends on the consumer after it is published on npm.
Example 1: It is used by javascript repo that use yarn for dependency management. Running generate.sh will install dependency in the root node_modules folder that is not tracked in the repo's yarn.lock file. Also javascript repo that use yarn add flowtype-protoc-gen to install this package will install different versions of node_modules from 'package-lock.json' that's in the root repo, but those versions may not be used.

See #8

from flowtype-protoc-gen.

chrisgervang avatar chrisgervang commented on May 24, 2024

Maybe I'm not familiar enough with yarn. My understanding was that an npm package published with or without yarn will behave the same for the end user installing over npm because they are installing a "built" distribution of the package.

All of the devDependencies are ignored, and we don't have many dependencies

"@babel/polyfill": "^7.0.0",
"google-protobuf": "^3.6.1"

(the poly fill might actually be able to be removed)
It may make sense to move google-protobuf to peerDependency.

from flowtype-protoc-gen.

chrisgervang avatar chrisgervang commented on May 24, 2024

This is now published in prerelease on npm

from flowtype-protoc-gen.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.