Git Product home page Git Product logo

Comments (3)

chrisdavies avatar chrisdavies commented on July 17, 2024

I updated the file /test/eev.html so that it loads eev.min.js. Can you pull master down locally and open that file and confirm that it shows the tests passing?

Are you running UglifyJS on the eev.min.js or on eev.js? I don't usually re-uglify .min files, and I'm not sure what the behavior would be in that situation.

from eev.

soulchainer avatar soulchainer commented on July 17, 2024

It passes the tests, yes.

I think right now that probably I was doing something wrong or is a problem caused by the platform (Tumblr, don't judge me).

I just needed eev.min.js and I grabbed it manually from the repository and tried it. I'm not using a build system (this time), so I wasn't minifying anything myself (and I don't re-minify a minified script usually). But the minified version you have in the repository (that, according to the package.json should be minified with UglifyJS) wasn't working, so then I grabbed the eev.js and tried it unminified. And it worked. So, I imagined the problem was the minification, so I tried to minify it myself. First with UglifyJS โ†’ didn't work. Later with other minifiers, till I found one that worked :รพ (the mentioned ShrinkSafe).

But now that I saw your tests passing correctly with the minified version, I tried it in a plunker... and it runs without errors. And tried just now in Fiddle and works all right. And tried in another Tumblr and... It breaks. So it must be something in Tumblr what is messing with the script minified that way... I should have tried that before, I don't know why I didn't do it: this isn't the first weird error Tumblr causes me.

I feel very sorry for wasting your time, man. My apologies :(.

from eev.

chrisdavies avatar chrisdavies commented on July 17, 2024

Hey, no worries. I would have done exactly the same in your shoes. Strange to hear that it doesn't work on Tumblr. I'd be interested to hear back from you if you ever can figure out why that is! Meanwhile, I'll close this.

from eev.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.