Git Product home page Git Product logo

Comments (5)

chrisant996 avatar chrisant996 commented on September 24, 2024

When I run the script in a cmd with clink injected, Tab doesn't even do completion; it just inserts raw TAB characters.

I'll debug and fix both issues.

P.S. This used to work as of v1.4.0, so something has regressed since then.

v1.4.0

  • Fixed #370; Tab inside set /p var= mistakenly discards any previous input.

from clink.

chrisant996 avatar chrisant996 commented on September 24, 2024

When I run the script in a cmd with clink injected, Tab doesn't even do completion; it just inserts raw TAB characters.

The reason Tab completion isn't working for me is because the control parameter is NULL in the intercepted ReadConsoleW call.

set_ctrl_wakeup_mask(control ? control->dwCtrlWakeupMask : 0);

Oh, and that's because I have my CMD shortcuts configured to explicitly pass /f:off which turns off completion. There was a reason I did that, but I forget why. 🤷‍♂️

from clink.

chrisant996 avatar chrisant996 commented on September 24, 2024

@boka-boka What version of Clink are you using?
Can you share the full output from clink info?

When I run the test bat script in CMD with Clink v1.6.1 injected, I get the expected results:

image

from clink.

boka-boka avatar boka-boka commented on September 24, 2024

This is the output from clink info. Clearly an old version... I'll install the latest one to check my scenario.

clink  info
version  : 1.3.15.6e6e45
session  : 25644
binaries : C:\Program Files\ConEmu\ConEmu\clink
state    : C:\Users\evb\AppData\Local\clink
log      : C:\Users\evb\AppData\Local\clink\clink.log
settings : C:\Users\evb\AppData\Local\clink\clink_settings
history  : C:\Users\evb\AppData\Local\clink\clink_history
scripts  : C:\Program Files\ConEmu\ConEmu\clink ; C:\Users\evb\AppData\Local\clink
inputrc  : %clink_inputrc%
             (unset)
         : state directory
             C:\Users\evb\AppData\Local\clink\.inputrc
             C:\Users\evb\AppData\Local\clink\_inputrc
         : %userprofile%
             C:\Users\evb\.inputrc
             C:\Users\evb\_inputrc
         : %localappdata%
             C:\Users\evb\AppData\Local\.inputrc
             C:\Users\evb\AppData\Local\_inputrc
         : %appdata%
             C:\Users\evb\AppData\Roaming\.inputrc
             C:\Users\evb\AppData\Roaming\_inputrc
         : %home%
             C:\Users\evb\.inputrc
             C:\Users\evb\_inputrc

After installing latest version (version : 1.6.1.c7c448), it works very well.

Really sorry for this false alarm, and thanks a lot for your work on this great tool.

from clink.

chrisant996 avatar chrisant996 commented on September 24, 2024

Oh yeah, that explains it. It was fixed in 1.4.0 a while back.

Thanks for reporting it, and I'm glad it's working now after the update.

from clink.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.