Comments (9)
there is a cver all -localonly but it seems slow. But does that do a better job?
I have an IComparer at work that could serve this purpose. Then it would become versionQuery.ToList().Sort(New VersionComparer).Last();
I'll if I can adapt the comparer to do what we need. And write the needed unittests.
from chocolateygui.
cver all -localonly
works fine. But it's really not very fast. Yes, a VersionComparer would work fine I think.
from chocolateygui.
added failing tests for this.
from chocolateygui.
@chrissie1: Did you purposefully remove the file system service from the PackageManager during this commit? It looks like it was still there in your prior commit, but then it went away in this one and the dialog boxes during tests came back. I'd add it back in, but it looked like you might have done it on purpose and didn't want to get in a commit fight :)
from chocolateygui.
Nope thats was accidental, git messed up the merge, i guess, yeah it was git's fault
from chocolateygui.
FIGHT, FIGHT, FIGHT!!! :-)
from chocolateygui.
@cemrich Here is the gist to the comparer. Needs some more tests but I think it should work. Based on the full packagename. https://gist.github.com/chrissie1/4959638
from chocolateygui.
All fixed.
@chrissie1 are those 4 package name parsing tests added for this issue or a different one? I can fix them to properly parse out name, version, and pre but wouldn't want to step on any work being done to manage the sorting.
Also, should there have a been a link to the gist you just mentioned somewhere?
from chocolateygui.
The link is there. You need to look better.
I think they are unrelated. This one is about the fact that The .Last() call did not give the correct version because it does stringsorting. So I made the sorter to sort them correctly so that you can find the last version more easily. My sorter is based on the directoryname but it easily adapted to work on a Package
from chocolateygui.
Related Issues (20)
- Null reference exception is thrown when accessing the Chocolatey GUI settings screen HOT 6
- Upgrading to Latest 2.0.0 and 6.0.0 of Chocolatey Products
- Package version normalization is not being applied everywhere HOT 1
- Error message "Unable to resolve dependencies. 'package A' is not compatible with ..." not displayed in the GUI
- Duplicate registry keys HOT 2
- Chocolatey GUI throws repeated HttpRetryHandler warnings while attempting to update Chocolatey package list HOT 8
- Opening settings window crash HOT 2
- Chocolatey GUI should honour the proxy settings of Chocolatey CLI when downloading the icons
- Provide ability to use option for Chocolatey CLI commands to skip cached HTTP query results HOT 1
- Unexpected output in Console and Log
- Allow default sort order to be a setting in Chocolatey GUI
- Exit code 1603 when trying to install chocolateygui 1.1.0 HOT 3
- Exit code 1603 when trying to install chocolateygui 1.1.0 HOT 11
- Configure Chocolatey GUI to prompt for repository credentials like the Choco CLI HOT 1
- Unhandled Exception with GUI despite multiple un- and re-installs HOT 2
- Provide a way to ignore HttpCache when retrieving packages
- Make the package view for remote sources and This PC source consistent
- Add feature to automatically refresh the view on install, upgrade, reinstall or uninstall
- Add clearer messaging when downgrading a package HOT 1
- Failed to start application. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chocolateygui.