Authentication system about distant HOT 4 CLOSED

Each authentication method implements a trait like this:

trait AuthMethod {
    /// Unique id like "none", "userauth", "static_key", or "reauth", used to both communicate available methods and map methods when stored
    fn id(&self) -> &'static str;

    /// Performs authentication by issuing challenges, verifications, and more using the `authenticator`
    ///
    /// NOTE: We use a trait obj reference instead of a generic so this trait can also be a trait obj
    async fn authenticate(&self, authenticator: &mut dyn Authenticator) -> io::Result<()>;
}

We can cast using as to get the trait obj reference:

let authenticator = SomeAuthenticator::new();
let method = SomeAuthMethod::new();
method.authenticate(&mut authenticator as &mut dyn Authenticator).await.unwrap();

from distant.

The ServerExt needs to be broken out into a Server struct with a generic that is a ServerHandler with the methods to invoke (on_accept and on_request). The Server will always perform a handshake and authentication with the client - it's a requirement - and will take a Vec<Box<dyn AuthMethod>> as one of its parameters to support reporting the types of authentication available, performing the authentication, and verifying only authentication methods provided will be used (e.g. client cannot send "none" and have it be used if the server doesn't have it).

This is why we want a Server struct with the methods as a struct field. This will also enable having a TcpServerBuilder, UnixSocketServerBuilder, and WindowsPipeServerBuilder with associated methods on our Server in the same way as what we've done with the Client in our branch.

from distant.

Refactoring done in current branch, so closing out.

from distant.

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

from distant.