I'm applying a patch of a diff between the following nodes using the current master ve

Thanks a lot for pointing this out! Are you using <a href="https://g

Are you using <a href="https://github.com/rustwasm/console_error_panic_ho

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Unreachable reached on virtual_dom_rs::patch::patch about percy HOT 7 CLOSED

chinedufn commented on July 28, 2024

Unreachable reached on virtual_dom_rs::patch::patch

from percy.

Comments (7)

chinedufn commented on July 28, 2024 1

Thanks a lot for pointing this out!

Are you using console_error_panic_hook? If not that helps tremendously with the stack traces.

Maybe you can reproduce this somehow in a test? I currently don't know how.

So we typically just create a new diff_patch.rs test case and see if it fails.

percy/crates/virtual-dom-rs/tests/diff_patch.rs

Lines 20 to 33 in bb39471

 #[wasm_bindgen_test] 

 fn replace_child() { 

 DiffPatchTest { 

 desc: "Replace a root node attribute attribute and a child text node", 

 old: html! { 

 <div> 

 Original element 

 </div> 

 }, 

 new: html! { <div> Patched element</div> }, 

 override_expected: None, 

 } 

 .test(); 

 }

wasm-pack test crates/virtual-dom-rs --firefox --headless --test diff_patch # Run browser tests

These tests make sure that you can diff and patch in both directions between two VirtualNode trees.

Basically it's the change from   to a .

I've been able to reproduce the issue thanks to your example

https://github.com/chinedufn/percy/blob/fix-62/crates/virtual-dom-rs/tests/diff_patch.rs#L163-L173

Will take a look (not tonight).

Thanks!!

from percy.

dbrgn commented on July 28, 2024 1

Great! I can probably give this a try tomorrow (unless you find time tonight).

from percy.

chinedufn commented on July 28, 2024

FWIW another place that relates to this is the html macro tests

percy/crates/html-macro-test/src/lib.rs

Lines 215 to 228 in 4a2770c

 #[test] 

 fn vec_of_nodes() { 

 let children = vec![html! { <div> </div>}, html! { <strong> </strong>}]; 

 let mut expected = VirtualNode::new("div"); 

 expected.children = Some(vec![VirtualNode::new("div"), VirtualNode::new("strong")]); 

 HtmlMacroTest { 

 desc: "Vec of nodes", 

 generated: html! { <div> { children } </div> }, 

 expected, 

 } 

 .test(); 

 }

But I took a look and the html macro is working fine so this looks like a diff or patch issue... I'll take a look

from percy.

dbrgn commented on July 28, 2024

Are you using console_error_panic_hook? If not that helps tremendously with the stack traces.

Oh, that's nice, thanks for pointing it out!

from percy.

chinedufn commented on July 28, 2024

Alright so I won't be able to take a look for a few days.

If you'd like to take a look at this in the meantime I'd be happy to answer any questions and/or point you towards where to look.

I've written up some documentation on the exact process to figure out what's going wrong.

https://chinedufn.github.io/percy/diff-patch/fixing-diff-patch-issues.html

from percy.

chinedufn commented on July 28, 2024

Alright so I added a test case with your example (thanks!) and it does indeed fail!

percy/crates/virtual-dom-rs/src/diff/mod.rs

Lines 267 to 280 in cb41f08

 // https://github.com/chinedufn/percy/issues/62 

 #[test] 

 fn issue_62() { 

 DiffTestCase { 

 old: html! { <span> <br /> </span> }, 

 new: html! { <span> a <br /> </span> }, 

 expected: vec![ 

 Patch::Replace(1, &VirtualNode::text("a")), 

 Patch::AppendChildren(0, vec![&VirtualNode::new("br")]), 

 ], 

 description: "Replace text node", 

 } 

 .test(); 

 }

Just to keep you posted, I should be able to take a look either tonight or within the next couple of days.

Cheers!

from percy.

chinedufn commented on July 28, 2024

@dbrgn so my screenshot above was totally wrong. The diffing was working fine I just had my Vec<Patch> in the test case backwards. The left and right in that screenshot have the save vector contents just in different orders...

Anyways.. the real issue was a patching issue.

The Patch::Replace(...) handler would treat text nodes like regular nodes so we were trying to create an element but we weren't providing a tag.. So basically calling document.create_element("");

#65

from percy.

Unreachable reached on virtual_dom_rs::patch::patch about percy HOT 7 CLOSED

Comments (7)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	#[wasm_bindgen_test]
	fn replace_child() {
	DiffPatchTest {
	desc: "Replace a root node attribute attribute and a child text node",
	old: html! {
	<div>
	Original element
	</div>
	},
	new: html! { <div> Patched element</div> },
	override_expected: None,
	}
	.test();
	}

	#[test]
	fn vec_of_nodes() {
	let children = vec![html! { <div> </div>}, html! { <strong> </strong>}];

	let mut expected = VirtualNode::new("div");
	expected.children = Some(vec![VirtualNode::new("div"), VirtualNode::new("strong")]);

	HtmlMacroTest {
	desc: "Vec of nodes",
	generated: html! { <div> { children } </div> },
	expected,
	}
	.test();
	}

	// https://github.com/chinedufn/percy/issues/62
	#[test]
	fn issue_62() {
	DiffTestCase {
	old: html! { <span> <br /> </span> },
	new: html! { <span> a <br /> </span> },
	expected: vec![
	Patch::Replace(1, &VirtualNode::text("a")),
	Patch::AppendChildren(0, vec![&VirtualNode::new("br")]),
	],
	description: "Replace text node",
	}
	.test();
	}