Comments (6)
Added both examples to the tests and I believe this is fixed in 0.4.4
. Thanks @siedentop for tracking it down in the source.
from cmake_format.
I think this is the same as #55. A comment should preclude formatting to a single line. Hopefully can fix them both quickly.
from cmake_format.
Ah, on second thought, I see this is a different issue: The paren can't be packed onto the same line because of the comment.
from cmake_format.
Thanks for this tool!
This ticket's issue still seems to be a problem for me in 0.4.3 (which from 'releases' ought to contain the fix already):
Input:
target_link_libraries(peerdiscovery PUBLIC
${COMMON_LIBRARIES}
# add more library dependencies here
)
Output:
target_link_libraries(peerdiscovery
PUBLIC ${COMMON_LIBRARIES}
# add more library dependencies here)
which produced CMake errors:
[windows_build_and_unittest] CMake Error at peerdiscovery/CMakeLists.txt:52:
[windows_build_and_unittest] Parse error. Function missing ending ")". End of file reached.
from cmake_format.
I still see this. Here is an example:
Input:
cmake_minimum_required(VERSION 3.13.0)
project(minimal_example)
find_package(foobar REQUIRED
COMPONENTS some_component
# some_other_component # This is a very long comment, and actually the second comment in this row.
)
Output:
cmake_minimum_required(VERSION 3.13.0)
project(minimal_example)
find_package(foobar REQUIRED
COMPONENTS some_component
# some_other_component # This is a very long comment,
# and actually the second comment in this row.)
Notice the closing parens on the last comment line.
from cmake_format.
I can confirm that this is fixed now. Thank you, @cheshirekow !
from cmake_format.
Related Issues (20)
- Extension doesn't show up in vscode results for category:formatters cmake
- line_width causes seemingly inconsistent formatting
- Support pre-commit? HOT 2
- Could not find cmake-annotate
- Documentation of override_spec
- Master failing tests
- Add option to provide original file path for cases when IDE uses temporary file
- Getting spawnsync EPIPE error from VS Code with cmake-format HOT 1
- Release of Windows executable build?
- VS Code extension: ${workspaceFolder} prefixed with '/' on Windows
- Option to always wrap arguments vertically HOT 2
- cmake-format merges two comment lines and breaks cmake-lint disable comment HOT 1
- cmake-lint: disable not working as expected? HOT 1
- Wrong assumption in get_lint that works on sorted suppression events
- Specifying a config file in `pre-commit` hook GitHub actions HOT 6
- Feature for control the style of `endif()` statement?
- Is this project still maintained? HOT 3
- exception: PackageNotFoundError with Python 3.12.3 HOT 2
- AttributeError in ctest-to: ‘dict’ object has no attribute ‘parse_db’
- want new version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmake_format.