Steps to Reproduce Create a file <code class=

Added both examples to the tests and I believe this is fixed in <code class="notransla

I think this is the same as <a class="issue-link js-issue-link" data-error-text="Faile

I still see this. Here is an example: Input: <div class="snippet

I can confirm that this is fixed now. Thank you, <a class="user-mention notranslate" d

Incorrect Formatting of Function Call With Trailing Comment about cmake_format HOT 6 CLOSED

cheshirekow commented on August 20, 2024

Incorrect Formatting of Function Call With Trailing Comment

from cmake_format.

Comments (6)

cheshirekow commented on August 20, 2024 1

Added both examples to the tests and I believe this is fixed in 0.4.4. Thanks @siedentop for tracking it down in the source.

from cmake_format.

cheshirekow commented on August 20, 2024

I think this is the same as #55. A comment should preclude formatting to a single line. Hopefully can fix them both quickly.

from cmake_format.

cheshirekow commented on August 20, 2024

Ah, on second thought, I see this is a different issue: The paren can't be packed onto the same line because of the comment.

from cmake_format.

michaelmaguire commented on August 20, 2024

Thanks for this tool!

This ticket's issue still seems to be a problem for me in 0.4.3 (which from 'releases' ought to contain the fix already):

Input:

target_link_libraries(peerdiscovery PUBLIC
    ${COMMON_LIBRARIES}
    # add more library dependencies here
)

Output:

target_link_libraries(peerdiscovery
                      PUBLIC ${COMMON_LIBRARIES}
                             # add more library dependencies here)

which produced CMake errors:

[windows_build_and_unittest] CMake Error at peerdiscovery/CMakeLists.txt:52:
[windows_build_and_unittest]   Parse error.  Function missing ending ")".  End of file reached.

from cmake_format.

siedentop commented on August 20, 2024

I still see this. Here is an example:

Input:

cmake_minimum_required(VERSION 3.13.0)
project(minimal_example)

find_package(foobar REQUIRED
             COMPONENTS some_component
                        # some_other_component # This is a very long comment, and actually the second comment in this row.
          )

Output:

cmake_minimum_required(VERSION 3.13.0)
project(minimal_example)

find_package(foobar REQUIRED
             COMPONENTS some_component
                        # some_other_component # This is a very long comment,
                        # and actually the second comment in this row.)

Notice the closing parens on the last comment line.

from cmake_format.

siedentop commented on August 20, 2024

I can confirm that this is fixed now. Thank you, @cheshirekow !

from cmake_format.

Recommend Projects