Add selector filtering support for parent(), next(), prev(), and children() about cheerio HOT 5 CLOSED

+1 - It seems this functionality is also missing or broken for children().

from cheerio.

Thanks, I've updated the issue.

These filters are really baked into jQuery, so I'm trying to find a good balance between implementing what jQuery has and rolling my own internals.

from cheerio.

@eirikurn Hey, so I got a chance to look at this closer – it looks like children(selector) was implemented. Do you have an example of it not working?

from cheerio.

Yeah, I kinda meant it was broken, or didn't work like in jQuery...

Currently it applies the selector filter onto all descendants... like find(), instead of applying it only on the immediate children of the matched elements. Or that's how it looked to me in my test case and looking at the code.

Great library though. I can't wait for soupselect to learn more selectors (like > + ~ and some : filters), and htmlparser to become more forgiving (for pages that forget closing tags). Guess I should put on my contribution gloves soon :)

from cheerio.

Thanks! Oh okay yah good call - definitely goes deeper than 1 level. I'll fix this soon - thanks for point it out!

Haha, yah that would be nice - soupselect and node-htmlparser haven't been updated in foreverrr. The pending pull requests for each of those libraries have some goodies and I'm starting to think I need to assume responsibility for them :-/

from cheerio.