Comments (4)
Thanks Trevor for the report.
Do you want to try and create a query to catch this case?
https://docs.kics.io/latest/creating-queries/
We'll be happy to help if you're up to the challenge (:
from kics.
I'll have to see what level of effort is required to contribute that query! Just wanted to get it documented for starters. :)
from kics.
I'll have to see what level of effort is required to contribute that query! Just wanted to get it documented for starters. :)
There is a secrets query that would catch this in a different way. It goes off of specific formatting. Your example access key and secret do not look like real ones. Just a note in case that would work for you
from kics.
Yeah, I know they aren't real access key and secret key. Posting real ones wouldn't have been prudent.
Also keep in mind that you might not necessarily find "real" values hard-coded in these templates. You might also find insecure references to variables, such as var.aws_key_id
or var.aws_secret_key
. In that scenario, a secrets detector wouldn't be adequate.
The AWS provider for Terraform accepts environment variables as inputs, so you don't need to specify these credential values in the provider block at all.
I wouldn't only consider this a "critical" level issue if someone did indeed hard-code credentials. Specifying variable references could still be a "warning" level or similar, and recommend using environment variables. There's not really a right or wrong way, just suggestions to help developers understand their options.
from kics.
Related Issues (20)
- feat(update): install jq on checkmarks/KICS:debian container HOT 1
- feat(cwe): add CWE information to docker-compose queries
- bug(openapi): operationScheme tags shown as missing required fields
- bug(openapi): false positive - wrongly required `items` for string type HOT 4
- bug(aws): false positive on Hardcoded AWS Access Key In Lambda, (2564172f-c92b-4261-9acd-464aed511696) HOT 3
- bug(core): security issue: CVE-2024-3817 found HOT 4
- bug(dockerfile): apt-get Missing '-y' To Avoid Manual Input` HOT 2
- query<Kubernetes>: kics-scan ignore-block not working for YAML files HOT 1
- bug(cloudformation): dynamoDB Table Not Encrypted
- bug(cloudformation): hardcoded AWS Access Key In Lambda
- bug(dockercompose): no-new-privileges:true is going to be deprecated in favor of "="
- bug(terraform): wrong detection of unused security group HOT 4
- bug(terraform): policy without principal false positive HOT 4
- query(cloudformation): ecs cluster not encrypted at eest should be ecs task efs volume attachment not encrypted in transit
- query(kubernetes): problem with KICS Custom query
- feat(ansible): playbook scanning; allow Ansible scanning for both YAML and YML files
- bug(terraform): scan results differ between .tf and respective .tfplan file
- feat(Accuracy Benchmark): update the KICS Accuracy Benchmark results for v2.x HOT 1
- bug(assets/queries/terraform/azure/ssh_is_exposed_to_the_internet/metadata.json): Grammar of Title and Description could be more specific. HOT 1
- bug(contribution_guide): golint is deprecated HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kics.