Git Product home page Git Product logo

Comments (10)

supersnager avatar supersnager commented on July 29, 2024 3

@HwangTaehyun @kolt-suzuki

The PR from @HwangTaehyun uses keypress event which is unfortunately deprecated (source: https://developer.mozilla.org/en-US/docs/Web/API/Document/keypress_event#Deprecated)

I don't want to keep deprecated features in the code.
However, I have done some research and it looks like there is no other workaround for this chrome bug.
So I have tested the PR and it's ok. I will merge it, but @HwangTaehyun please change the commit message as I mentioned in the PR comment.

from chat-ui-kit-react.

kolt-suzuki avatar kolt-suzuki commented on July 29, 2024 1

This issue is critical for Japanese users too.
I hope it would be merged quickly.

from chat-ui-kit-react.

supersnager avatar supersnager commented on July 29, 2024 1

@HwangTaehyun Thank you for your contribution!

from chat-ui-kit-react.

supersnager avatar supersnager commented on July 29, 2024

@HwangTaehyun Thanks for PR. I will reproduce this bug before merging, and check if everything works for other edge cases as well.

from chat-ui-kit-react.

HwangTaehyun avatar HwangTaehyun commented on July 29, 2024

I checked again, and it works fine in Chrome on Windows, and it seems that this problem occurs in Chrome on Mac. Please note. Thank you!

from chat-ui-kit-react.

supersnager avatar supersnager commented on July 29, 2024

@HwangTaehyun Thanks!

from chat-ui-kit-react.

supersnager avatar supersnager commented on July 29, 2024

@kolt-suzuki I will take care of it this week.

from chat-ui-kit-react.

bibek-magar avatar bibek-magar commented on July 29, 2024

Waiting for ticket to merged....

from chat-ui-kit-react.

supersnager avatar supersnager commented on July 29, 2024

🎉 This issue has been resolved in version 1.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

from chat-ui-kit-react.

HwangTaehyun avatar HwangTaehyun commented on July 29, 2024

@supersnager Thank you for your effort!

from chat-ui-kit-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.