Git Product home page Git Product logo

Comments (2)

STRRL avatar STRRL commented on June 17, 2024

Hi @Yseona, AWSChaos and GCPChaos require read permission on secrets, and PodChaos pod-failure requires updates the image field of pods.

So the rbac is expected.

I am going to close this comment, please feel free to reopen it if you have any other ideas.

from chaos-mesh.

kaaass avatar kaaass commented on June 17, 2024

@STRRL I recheck the code but I think the mentioned permissions are not used. Please tell me if I missed sth.

For AWSChoas, the code uses the get verb, but list verb is not used.

chaos-mesh/controllers/chaosimpl/awschaos/ec2restart/impl.go

Lines 56 to 61 in 6411f53

if awschaos.Spec.SecretName != nil {
secret := &v1.Secret{}
err := impl.Client.Get(ctx, types.NamespacedName{
Name: *awschaos.Spec.SecretName,
Namespace: awschaos.Namespace,
}, secret)

GCPChaos is same. list verb seems not been used.

chaos-mesh/controllers/chaosimpl/gcpchaos/utils/utils.go

Lines 33 to 41 in 6411f53

if gcpchaos.Spec.SecretName != nil {
secret := &v1.Secret{}
err := cli.Get(ctx, types.NamespacedName{
Name: *gcpchaos.Spec.SecretName,
Namespace: gcpchaos.Namespace,
}, secret)
if err != nil {
return nil, err
}

For PodChaos, we actually use the patch verb. So the update verb is indeed not used.

chaos-mesh/controllers/chaosimpl/podchaos/podfailure/impl.go

Line 86 in 6411f53

err = impl.Patch(ctx, pod, client.MergeFrom(&origin))

Among them, I think list verb of secrets verb may cause some security risks to some extent, since it allows users to inspect all available secrets. If it is not used, remove it might be worth-trying.

from chaos-mesh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.