what about using cni/plugins/ns instead of nsenter? about chaos-mesh HOT 4 CLOSED

@YangKeao @cwen0 PTAL

from chaos-mesh.

@yeya24 Thanks for your suggestion 🍻 . In the previous version of chaos-mesh, we setns through github.com/vishvananda/netns pkg. In #31, chaos-mesh turned to use nsenter to enter a network namespace.

According to the document you have shared with us, after go 1.10 we can work with network namespace in go safely.

I will take a look at what changes have been made by go 1.10 and how it solved problems issued by weavenet.

Controling networkspace in a "programmable" way is definitely better than using nsenter and the limitation (require go >= 1.10) is surely acceptable. I will work on this right after Spring Festival (or would you contribute to chaos-mesh 😄 ? )

from chaos-mesh.

@YangKeao Thanks. To be honest, I haven't noticed that network ns leakage before. I am not sure whether this package is safe enough, though it is used in CNI. I think I can investigate more and test locally first for this plan.

from chaos-mesh.

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

from chaos-mesh.