Comments (3)
Not fully solving the issue, but possibly a pointer to the root cause, I found that removing changie
files
.changes/
.changie.yaml
appears to confuse the bot in some way.
In a different branch where I only add the changesets tooling, and do not remove any files I see:
🦋 Changeset detected
If I run:
git rm -r .changie.yaml .changes/
git commit -m 'remove changie'
git push
the PR comment is updated to:
⚠️ No Changeset found
.changeset/
still exists after the previous operation:
❯ tree .changeset/
.changeset/
├── README.md
├── config.json
└── fair-walls-join.md
from bot.
Renaming the files does not immediately confuse the bot:
git mv .changes .no-more-changie
git commit -m 'git mv .changes .no-more-changie' --no-verify
git push
still gives the expected:
🦋 Changeset detected
However, even after renaming, removing the files confuses the bot again:
git rm -rf .no-more-changie
git commit -m 'git rm .no-more-changie' --no-verify
git push
puts us back to:
⚠️ No Changeset found
from bot.
❓ is there a limit to the number of results/files returned in octocat calls?
I have another PR in a different repo where I believe I followed the same process and the bot's fine.
The only obvious difference I can see is "Files Changed: 81" versus "Files Changed: 18"
Note: Responses include a maximum of 3000 files. The paginated response returns 30 files per page by default.
source: https://octokit.github.io/rest.js/v19#pulls-list-files
from bot.
Related Issues (20)
- Do not comment on some PRs, based on private packages or changed path? HOT 2
- Remove ignored/private packages on "add a changeset if you're a maintainer" link
- Ignore certain branches
- Changeset bot is including changesets not in the PR branch
- Consider moving the bot back to Github Actions HOT 3
- Support custom commit message generators
- Change changeset path HOT 2
- Include changeset(s) verbatim in bot message?
- Wrong version bump HOT 1
- Reset changeset detection when PR base branch is changed
- Support subdirectories HOT 1
- Feature request: require config
- feat: CI check for validating `changedFilePatterns`
- Running changesets bot on all previously opened PRs
- [💡 Feature request]: Previewing the changesets in Pull Requesst comment
- Make 'Changeset detected' look more different from 'No Changeset found'
- Feature request: option to turn off Changeset detected message
- Error when validating changeset config with root level package HOT 1
- Different message for PRs that do a version bump
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bot.