Comments (7)
I'd possibly hide it under a collapse so that it doesn't generate too long a comment.
from bot.
I was originally going to say 'no', but after thinking about it a bit more, I think the answer is 'yes', this would be a good addition to how the bot works.
There's an alternative if you want to really enforce this which is to block CI unless there's a changeset for each package in the PR which this bot wouldn't want to do. You can unblock CI by generating an empty
changeset for a package that doesn't need a release. Sadly, the places I've seen this done are close-sourced.
from bot.
I think for us it's more that we want the visibility that a PR changes X, Y & Z package, and only X and Z have a changeset. I don't think we would like to actually block the CI (e.g. in changeset action) if it's missing one.
So in that sense it's similar to the current bot behavior, which is just sending a message for visibility, but extended to have more information.
from bot.
Yeah I think this would be a good thing to add.
from bot.
What's the status of this?
We have the same problem, we use changeset bots but it does not work well with a monorepo one often will forget to add changesets files.
The problem by enabling changesets files to be required on the whole repo is that it forces one to have changesets file even for directories that includes a package.json but only are deployments and not packages published to npm.
from bot.
I think we're running into the same issue. We only use changesets for a portion of our repo (everything in a packages/
directory), but there are many other directories that we don't want to require changesets for. This is a blocker for using this bot, as the majority of PRs will not be touching the packages/
directory, and thus shouldn't get a comment that may mislead contributors.
from bot.
I think we're running into the same issue. We only use changesets for a portion of our repo (everything in a
packages/
directory), but there are many other directories that we don't want to require changesets for. This is a blocker for using this bot, as the majority of PRs will not be touching thepackages/
directory, and thus shouldn't get a comment that may mislead contributors.
Yeah we have the same issue at work, we created a script at work that incrementally applies all the changesets and reverts eventual apply's to package.json files in directories we don't want to be included when running the changeset version
command.
Been thinking that there should be some way of in the changeset config.json to specify which packages or directory patterns to be included as part of changeset algorithm, and eventual individual settings per such specific package or directory patterns.
In many config systems one can tell which directories or packages should be considered to be included as part of their heuristics, this is a feature that seems to be missing here and many could benefit from.
from bot.
Related Issues (20)
- Question: bot not running? HOT 3
- improvements to bot success message
- improvements to bot warning message
- run prettier on bot changeset suggestion HOT 1
- Bump package versions HOT 1
- Do not comment on some PRs, based on private packages or changed path? HOT 2
- Remove ignored/private packages on "add a changeset if you're a maintainer" link
- Ignore certain branches
- Changeset bot is including changesets not in the PR branch
- Consider moving the bot back to Github Actions HOT 3
- Support custom commit message generators
- Change changeset path HOT 2
- Include changeset(s) verbatim in bot message?
- Wrong version bump HOT 1
- Reset changeset detection when PR base branch is changed
- Support subdirectories HOT 1
- Feature request: require config
- feat: CI check for validating `changedFilePatterns`
- Running changesets bot on all previously opened PRs
- [💡 Feature request]: Previewing the changesets in Pull Requesst comment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bot.