Comments (2)
You definitely have a point. We designed the select machine this way initially as you mentioned.
Closing the select when the Tab key is pressed limits the composition with other composite widgets scenarios:
- select + tabs
- select + combobox
- select + treeview
We tried these compositions and decided to go with our current direction. The native MacOS select listbox blocks the use of the tab key, similar to how Radix UI solves this.
Based on the APG guide, I also think closing and selecting the focused option when the tab key is pressed could be unexpected. We treat the APG guideline as a baseline, not a "rule" to be followed by the letter; it's all subject to testing.
Thanks for understanding.
from zag.
Hi @segunadebayo, thanks for your reply.
I can understand that you would like to be more flexible when it comes to composition. However, composition of components is more likely to be the exception. I would therefore have preferred at least a control via a property instead of completely deactivating this feature.
Too bad, but thanks anyway.
from zag.
Related Issues (20)
- Bug: TagsInput does not allow for repeat pasting and undo. HOT 1
- docs: typo HOT 1
- Testing Select with Jest gives dom.getContentEl().scrollTo is not a function. HOT 2
- Switch useMachine type error HOT 2
- support editing props for `editable.root` HOT 2
- Nested menu closes on its own without clicking outside HOT 1
- NumberInput stops responding to up/down/enter once enter is pressed HOT 1
- Progress Circle indeterminate mode animation not working as expected HOT 2
- support deno
- Closing a nested dialog focuses the first focusable element in the parent dialog. HOT 2
- Clicking outside of a dialog on mobile passes click events through
- Support modality for Menu
- Multiple tooltips on screen at the same time
- aria-hidden behaviour doesn't play well with ProseMirror
- Popover trigger does not regain focus when closing with close trigger. HOT 1
- Controlled popovers does not return focus to popover trigger when closed HOT 1
- Docs(whats-a-machine): connect function does not return `getButtonProps` function
- Tree View: Selected item should not regain focus when reentering the tree.
- pauseOnInteraction doesn't exist on toast machine
- FileUpload: "value" property
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zag.