Comments (5)
Maybe we can do it based on modified files, e.g. if only edits in docs/**
then just run linting, spellcheck, .. and no test suites
from lodestar.
Is there anything else we foresee not requiring status check tests to run?
from lodestar.
I personally would love to see spec-tests being skippable for unrelated PRs
Yeah me too. There are some PRs that shouldn't need to go through these when they obviously don't modify for the functionality of Lodestar in any way.
Currently, for unstable
merge, the tests that must pass are:
- Spec tests (20)
- Unit Tests (20)
- Lint (20)
(Note, it shouldn't even be this minimal, but due to ongoing work for other tests, this is currently the setting to bypass inconsistencies)
All tests for PRs:
- Benchmark / run (pull_request)
- CodeQL / Analyze (javascript) (pull_request)
- Check docs / Docs spellcheck (pull_request)
- Lint PR title / Validate PR title (pull_request_target)
- Sim merge execution/builder tests / Sim merge tests (pull_request) S
- Sim tests / Build (pull_request)
- Tests / Build (20) (pull_request)
- Tests / Lint (20) (pull_request)
- Sim tests / Multifork sim test (pull_request)
- Sim tests / Endpoint sim tests (pull_request)
- Tests / Type Checks (20) (pull_request)
- Sim tests / Deneb sim tests (pull_request)
- Tests / E2E Tests (20) (pull_request)
- Sim tests / Eth backup provider sim tests
- Tests / Browser Tests (20) (pull_request)
- Sim tests / Mixed clients sim tests (pull_request)
- Tests / Spec tests (20) (pull_request)
- Tests / Unit Tests (20) (pull_request)
- license/cla
For things that don't require extensive testing (docs changes, some repo maintenance chores, etc.), we should just have it run:
- Check docs / Docs spellcheck (pull_request)
- Lint PR title / Validate PR title (pull_request_target)
- license/cla
Maybe we can do it based on modified files, e.g. if only edits in docs/** then just run linting, spellcheck, .. and no test suites
There are some things that don't necessarily touch only docs/**
. For example, some website maintenance to our docs are labeled as chore:
and perhaps those could be excluded too? This is why I thought of the label method as a conditional for the CI to skip certain tests and can be appended by the PR author based on their judgement and the reviewers.
from lodestar.
Related Issues (20)
- Change MAX_EFFECTIVE_BALANCE will cause prysm or lighthouse failed to sync with lodestar
- Synchronize keys between validator client and external signer HOT 2
- Grafana shows warning if metric name does not follow naming convention
- Nimbus VC to Lodestar BN shows attestation errors HOT 9
- Allow voluntary exit command to write to file rather than publish
- Lodestar CL < > Prysm VC incompatibility HOT 2
- Lodestar CL < > Nimbus VC incompatibility HOT 14
- Lodestar CL < > Teku VC incompatibility HOT 2
- Nimbus CL < > Lodestar VC incompatibility HOT 7
- Grandine CL < > Lodestar VC incompatibility HOT 16
- Simplify publish workflows
- getHealth should return 206 status code if EL is syncing / optimistic HOT 1
- dependabot: CI is failing to upload codecov data HOT 1
- Support connecting multiple external signers to validator client
- Error signing attestation - Corruption: bad entry in block HOT 1
- Ensure light-client can be bundled nodejs crypto free
- Review `Buffer.from` usage
- High outliers for some REST API responses HOT 2
- Integrate and schedule CI for Assertoor testing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lodestar.