.to.have.been.called.with repeating params about chai-spies HOT 8 CLOSED

1.0.0 released! Hooray!

from chai-spies.

This seems to be an expected behavior of the actual algorithm that checks the call argument. If this is true, I can add the fix to my fork and send the pull request if, of course, other contributors agree.

I'll soon take a look again to the algorithm and come back to you.

After taking a look again to the algorithm and the tests, this should actually work.

  Chai Spies
    .with(arg, ...)
      √ checks spy calls with repeating params (89ms)

There may be another factor acting within this issue.

from chai-spies.

You need to use with.exactly which will check order of args.

Please close issue if that works for you

from chai-spies.

Thanks, using .with.exactly(1, 1) worked here, though I consider it a workaround rather than a solution of issue.

I still can't understand why .with assertion can't handle repeating params:

it('checks spy calls with unique params', () => {
    const object = {};
    const fooFunction = chai.spy.on(object, 'foo');
    object.foo(1, 2, 3);
    chai.expect(fooFunction).to.have.been.called.with(2);
  });

  it('checks spy calls with repeating params', () => {
    const object = {};
    const fooFunction = chai.spy.on(object, 'foo');
    object.foo(1, 2, 2);
    chai.expect(fooFunction).to.have.been.called.with(2);
  });

Second test fails while first one passes which isn't the obvious behavior IMHO. Yes I could use .with.exactly and check order of all three args, but I think the order isn't significant if I just want to check if number 2 appeared among function args.

from chai-spies.

@olebokolo I would expect the tests in your original comment to pass. You say you have a patch? Please do send this over! with should handle repeating params.

from chai-spies.

I guess similar fix was added in e13621b

from chai-spies.

Yup! Looks like it. Let's cut a release now and @olebokolo can try and reproduce with chai spies 1.0.0

from chai-spies.

Works as expected with 1.0.0 👍
Thanks everybody

from chai-spies.