Git Product home page Git Product logo

Comments (7)

chadpaulson avatar chadpaulson commented on July 23, 2024

Hi Pavel,

The error occurs when the app attempts to bootstrap itself more than once. My apologies, as there is no need for alarm. This should fail silently, but I did not remove the debug logging before I committed.

from react-isomorphic-video-game-search.

borodyadka avatar borodyadka commented on July 23, 2024

I mean, new event listener has been added on every new request when you call gameStore.listen(...).
It can be possible memory leak and/or performance degradation.
I've tested (with ab -c 5 -t 10 http://localhost:3000/) on my own application with similar code and got performance degradation (from 100rps to 20rps).

from react-isomorphic-video-game-search.

andre0799 avatar andre0799 commented on July 23, 2024

I'm getting the same error and if it affects the performance I would like to know how to fix

from react-isomorphic-video-game-search.

chadpaulson avatar chadpaulson commented on July 23, 2024

This is an unfortunate byproduct of react-async, which requires node-fibers, when initializing state for the same component asynchronously multiple times.

I have been researching better ways of solving the problems outlined in this project, including isomorphic flux and server-side canonical URLs. As a result, I will likely update this project with a new implementation powered by alt and react-router.

from react-isomorphic-video-game-search.

nodegin avatar nodegin commented on July 23, 2024

is there any news about the updated version which powered by alt and react-router?

from react-isomorphic-video-game-search.

chadpaulson avatar chadpaulson commented on July 23, 2024

Between the rapidly evolving React/Flux landscape and other competing interests, I have decided not to make this a priority.

That said, I do hope to revisit this project, which is simply an example demo for some planned projects, in a month or so.

from react-isomorphic-video-game-search.

nodegin avatar nodegin commented on July 23, 2024

@chadpaulson I can wait for a month, this repo is the most minimal isomorphic one I seen.

from react-isomorphic-video-game-search.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.